From 8f60e4d679003235d6e4ac2f5f03eb757a84dde8 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Fri, 5 Feb 2010 22:56:11 +0000 Subject: [PATCH] fix incorrect encoding of SBB8mi that Kevin noticed. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@95448 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/X86/X86InstrInfo.td | 4 ++-- test/MC/AsmParser/X86/x86_32-encoding.s | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/lib/Target/X86/X86InstrInfo.td b/lib/Target/X86/X86InstrInfo.td index d604c176b15..0844bf9bd53 100644 --- a/lib/Target/X86/X86InstrInfo.td +++ b/lib/Target/X86/X86InstrInfo.td @@ -3028,8 +3028,8 @@ let isTwoAddress = 0 in { def SBB32mr : I<0x19, MRMDestMem, (outs), (ins i32mem:$dst, GR32:$src2), "sbb{l}\t{$src2, $dst|$dst, $src2}", [(store (sube (load addr:$dst), GR32:$src2), addr:$dst)]>; - def SBB8mi : Ii32<0x80, MRM3m, (outs), (ins i8mem:$dst, i8imm:$src2), - "sbb{b}\t{$src2, $dst|$dst, $src2}", + def SBB8mi : Ii8<0x80, MRM3m, (outs), (ins i8mem:$dst, i8imm:$src2), + "sbb{b}\t{$src2, $dst|$dst, $src2}", [(store (sube (loadi8 addr:$dst), imm:$src2), addr:$dst)]>; def SBB16mi : Ii16<0x81, MRM3m, (outs), (ins i16mem:$dst, i16imm:$src2), "sbb{w}\t{$src2, $dst|$dst, $src2}", diff --git a/test/MC/AsmParser/X86/x86_32-encoding.s b/test/MC/AsmParser/X86/x86_32-encoding.s index 3afdccaf95b..5161527ff08 100644 --- a/test/MC/AsmParser/X86/x86_32-encoding.s +++ b/test/MC/AsmParser/X86/x86_32-encoding.s @@ -1,5 +1,8 @@ // RUN: llvm-mc -triple i386-unknown-unknown %s -show-encoding | FileCheck %s fisttpl 3735928559(%ebx,%ecx,8) - # CHECK: encoding: [0xdb,0x8c,0xcb,0xef,0xbe,0xad,0xde] + +sbbb $0xfe,0xdeadbeef(%ebx,%ecx,8) + +# CHECK: encoding: [0x80,0x9c,0xcb,0xef,0xbe,0xad,0xde,0xfe] \ No newline at end of file -- 2.34.1