From 951740afb41bbae2c8b034bab1911c9ec949ccf4 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sun, 6 Jan 2008 01:12:44 +0000 Subject: [PATCH] simplify some code git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@45642 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/TableGen/InstrInfoEmitter.cpp | 24 ++++++++---------------- utils/TableGen/InstrInfoEmitter.h | 7 ++++--- 2 files changed, 12 insertions(+), 19 deletions(-) diff --git a/utils/TableGen/InstrInfoEmitter.cpp b/utils/TableGen/InstrInfoEmitter.cpp index 10962041e79..b3ca0aa9127 100644 --- a/utils/TableGen/InstrInfoEmitter.cpp +++ b/utils/TableGen/InstrInfoEmitter.cpp @@ -175,10 +175,7 @@ void InstrInfoEmitter::emitRecord(const CodeGenInstruction &Inst, unsigned Num, else OS << Inst.Name; - unsigned ItinClass = !IsItineraries ? 0 : - ItinClassNumber(Inst.TheDef->getValueAsDef("Itinerary")->getName()); - - OS << "\",\t" << ItinClass << ", 0"; + OS << "\",\t" << getItinClassNumber(Inst.TheDef) << ", 0"; // Try to determine (from the pattern), if the instruction is a store. bool isStore = false; @@ -258,28 +255,23 @@ void InstrInfoEmitter::emitRecord(const CodeGenInstruction &Inst, unsigned Num, OS << " }, // Inst #" << Num << " = " << Inst.TheDef->getName() << "\n"; } -struct LessRecord { +struct RecordNameComparator { bool operator()(const Record *Rec1, const Record *Rec2) const { return Rec1->getName() < Rec2->getName(); } }; + void InstrInfoEmitter::GatherItinClasses() { std::vector DefList = Records.getAllDerivedDefinitions("InstrItinClass"); - IsItineraries = !DefList.empty(); - - if (!IsItineraries) return; - - std::sort(DefList.begin(), DefList.end(), LessRecord()); + std::sort(DefList.begin(), DefList.end(), RecordNameComparator()); - for (unsigned i = 0, N = DefList.size(); i < N; i++) { - Record *Def = DefList[i]; - ItinClassMap[Def->getName()] = i; - } + for (unsigned i = 0, N = DefList.size(); i < N; i++) + ItinClassMap[DefList[i]->getName()] = i; } -unsigned InstrInfoEmitter::ItinClassNumber(std::string ItinName) { - return ItinClassMap[ItinName]; +unsigned InstrInfoEmitter::getItinClassNumber(const Record *InstRec) { + return ItinClassMap[InstRec->getValueAsDef("Itinerary")->getName()]; } void InstrInfoEmitter::emitShiftedValue(Record *R, StringInit *Val, diff --git a/utils/TableGen/InstrInfoEmitter.h b/utils/TableGen/InstrInfoEmitter.h index fe40b5803d7..5893d4473bf 100644 --- a/utils/TableGen/InstrInfoEmitter.h +++ b/utils/TableGen/InstrInfoEmitter.h @@ -16,6 +16,7 @@ #define INSTRINFO_EMITTER_H #include "TableGenBackend.h" +#include "CodeGenDAGPatterns.h" #include #include @@ -28,11 +29,11 @@ class CodeGenInstruction; class InstrInfoEmitter : public TableGenBackend { RecordKeeper &Records; - bool IsItineraries; + CodeGenDAGPatterns CDP; std::map ItinClassMap; public: - InstrInfoEmitter(RecordKeeper &R) : Records(R), IsItineraries(false) {} + InstrInfoEmitter(RecordKeeper &R) : Records(R), CDP(R) { } // run - Output the instruction set description, returning true on failure. void run(std::ostream &OS); @@ -46,7 +47,7 @@ private: std::map, unsigned> &OpInfo, std::ostream &OS); void GatherItinClasses(); - unsigned ItinClassNumber(std::string ItinName); + unsigned getItinClassNumber(const Record *InstRec); void emitShiftedValue(Record *R, StringInit *Val, IntInit *Shift, std::ostream &OS); std::vector GetOperandInfo(const CodeGenInstruction &Inst); -- 2.34.1