From 97555d1e20f3b63322d9a0a6e9d2192b22854618 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Mon, 14 Jul 2014 18:54:12 +0000 Subject: [PATCH 1/1] Look through addrspacecast when checking isDereferenceablePointer git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@212971 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/IR/Value.cpp | 3 ++ test/Transforms/LICM/hoist-bitcast-load.ll | 38 ++++++++++++++++++++++ 2 files changed, 41 insertions(+) diff --git a/lib/IR/Value.cpp b/lib/IR/Value.cpp index 35c241a608b..999685e15eb 100644 --- a/lib/IR/Value.cpp +++ b/lib/IR/Value.cpp @@ -543,6 +543,9 @@ static bool isDereferenceablePointer(const Value *V, const DataLayout *DL, return true; } + if (const AddrSpaceCastInst *ASC = dyn_cast(V)) + return isDereferenceablePointer(ASC->getOperand(0), DL, Visited); + // If we don't know, assume the worst. return false; } diff --git a/test/Transforms/LICM/hoist-bitcast-load.ll b/test/Transforms/LICM/hoist-bitcast-load.ll index 639dca5f17e..fa61eaf5b46 100644 --- a/test/Transforms/LICM/hoist-bitcast-load.ll +++ b/test/Transforms/LICM/hoist-bitcast-load.ll @@ -78,6 +78,44 @@ for.end: ; preds = %for.inc, %entry ret void } +; Make sure the basic alloca pointer hoisting works through an addrspacecast +; CHECK-LABEL: @test2_addrspacecast +; CHECK: load i32 addrspace(1)* %c, align 4 +; CHECK: for.body: + +; Function Attrs: nounwind uwtable +define void @test2_addrspacecast(i32 addrspace(1)* nocapture %a, i32 addrspace(1)* nocapture readonly %b, i32 %n) #0 { +entry: + %cmp6 = icmp sgt i32 %n, 0 + %ca = alloca i64 + %c = addrspacecast i64* %ca to i32 addrspace(1)* + br i1 %cmp6, label %for.body, label %for.end + +for.body: ; preds = %entry, %for.inc + %indvars.iv = phi i64 [ %indvars.iv.next, %for.inc ], [ 0, %entry ] + %arrayidx = getelementptr inbounds i32 addrspace(1)* %a, i64 %indvars.iv + %0 = load i32 addrspace(1)* %arrayidx, align 4 + %cmp1 = icmp sgt i32 %0, 0 + br i1 %cmp1, label %if.then, label %for.inc + +if.then: ; preds = %for.body + %1 = load i32 addrspace(1)* %c, align 4 + %arrayidx3 = getelementptr inbounds i32 addrspace(1)* %b, i64 %indvars.iv + %2 = load i32 addrspace(1)* %arrayidx3, align 4 + %mul = mul nsw i32 %2, %1 + store i32 %mul, i32 addrspace(1)* %arrayidx, align 4 + br label %for.inc + +for.inc: ; preds = %for.body, %if.then + %indvars.iv.next = add nuw nsw i64 %indvars.iv, 1 + %lftr.wideiv = trunc i64 %indvars.iv.next to i32 + %exitcond = icmp eq i32 %lftr.wideiv, %n + br i1 %exitcond, label %for.end, label %for.body + +for.end: ; preds = %for.inc, %entry + ret void +} + ; Make sure the basic alloca pointer hoisting works through a bitcast to a ; pointer to a smaller type (where the bitcast also needs to be hoisted): ; CHECK-LABEL: @test3 -- 2.34.1