From 9ca358021c2df17869cb20cae61f321a4b2ccd58 Mon Sep 17 00:00:00 2001 From: "Duncan P. N. Exon Smith" Date: Sun, 15 Mar 2015 06:53:32 +0000 Subject: [PATCH] IR: Default the Metadata::dump() argument "harder" after r232275 Use an overload instead of a default argument for `Metadata::dump()`. The latter seems to require calling `dump(nullptr)` explicitly when using a debugger, where as the former doesn't. Other than utility for debugging, there's NFC here. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@232315 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/IR/Metadata.h | 9 ++++++++- lib/IR/AsmWriter.cpp | 3 +++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/include/llvm/IR/Metadata.h b/include/llvm/IR/Metadata.h index 6ba0fd41730..a31bdbfac65 100644 --- a/include/llvm/IR/Metadata.h +++ b/include/llvm/IR/Metadata.h @@ -106,7 +106,14 @@ public: /// /// If \c M is provided, metadata nodes will be numbered canonically; /// otherwise, pointer addresses are substituted. - void dump(const Module *M = nullptr) const; + /// + /// Note: this uses an explicit overload instead of default arguments so that + /// the nullptr version is easy to call from a debugger. + /// + /// @{ + void dump() const; + void dump(const Module *M) const; + /// @} /// \brief Print. /// diff --git a/lib/IR/AsmWriter.cpp b/lib/IR/AsmWriter.cpp index 509fb423ff7..ea6822052d0 100644 --- a/lib/IR/AsmWriter.cpp +++ b/lib/IR/AsmWriter.cpp @@ -3289,6 +3289,9 @@ void Comdat::dump() const { print(dbgs()); } LLVM_DUMP_METHOD void NamedMDNode::dump() const { print(dbgs()); } +LLVM_DUMP_METHOD +void Metadata::dump() const { dump(nullptr); } + LLVM_DUMP_METHOD void Metadata::dump(const Module *M) const { print(dbgs(), M); -- 2.34.1