From 9dbb52ab5c9532002435e1b249c2313bb36570de Mon Sep 17 00:00:00 2001 From: Christopher Dykes Date: Mon, 18 Jul 2016 19:49:24 -0700 Subject: [PATCH] Make sure to return from atomicHashArrayInsertRaceThread Summary: Because, unfortunately, `pthread_exit` is not marked as noreturn in the pthread library primarily used on Windows, we need to return something to avoid errors. Reviewed By: yfeldblum Differential Revision: D3571465 fbshipit-source-id: 4713b2364d6584ae255fb83cd21406fdc33ee299 --- folly/test/AtomicHashMapTest.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/folly/test/AtomicHashMapTest.cpp b/folly/test/AtomicHashMapTest.cpp index f884b4ed..e62e8386 100644 --- a/folly/test/AtomicHashMapTest.cpp +++ b/folly/test/AtomicHashMapTest.cpp @@ -21,6 +21,8 @@ #include #include #include + +#include #include #include #include @@ -679,6 +681,7 @@ void* atomicHashArrayInsertRaceThread(void* /* j */) { } } pthread_exit((void *) numInserted); + folly::assume(false); } TEST(Ahm, atomic_hash_array_insert_race) { AHA* arr = atomicHashArrayInsertRaceArray.get(); -- 2.34.1