From 9f0c3ccfa97d84ee50a248574980b43d8a47e118 Mon Sep 17 00:00:00 2001 From: John Stultz Date: Tue, 21 May 2013 10:00:44 -0700 Subject: [PATCH] Revert "ARM: Make low-level printk work" This reverts commit 63d454ab530bb3ab5412aabd6be6ee8cd340888e. Per Andy's request, Andy's rational: "I don't think that makes any sense any more and should be removed, unless there's some case on Android side that really needs it. Vanilla has better DEBUG_LL support now since 2005 when that patch was introduced and the Android kernels will inherit it. I've reverted it in my tree since we commonly need DEBUG_LL on (but we don't need printascii garbling all our logging as if there was an echo in there). ...[It] basically forces all printk output down printascii() which is not what we want. earlyprintk=1 earlycon=ttyO2,115200n8 On your commandline will get you going [without this]" Change-Id: I1da455354b4a8ff3bc9c5f66f5a174b13e179ae6 Signed-off-by: John Stultz --- kernel/printk.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/kernel/printk.c b/kernel/printk.c index 9cb84eb1a9de..8212c1aef125 100644 --- a/kernel/printk.c +++ b/kernel/printk.c @@ -51,10 +51,6 @@ #define CREATE_TRACE_POINTS #include -#ifdef CONFIG_DEBUG_LL -extern void printascii(char *); -#endif - /* printk's without a loglevel use this.. */ #define DEFAULT_MESSAGE_LOGLEVEL CONFIG_DEFAULT_MESSAGE_LOGLEVEL @@ -1556,10 +1552,6 @@ asmlinkage int vprintk_emit(int facility, int level, */ text_len = vscnprintf(text, sizeof(textbuf), fmt, args); -#ifdef CONFIG_DEBUG_LL - printascii(text); -#endif - /* mark and strip a trailing newline */ if (text_len && text[text_len-1] == '\n') { text_len--; -- 2.34.1