From 9fe010ecf885b82ca16c3f1e3caf72b9823377f3 Mon Sep 17 00:00:00 2001 From: Owen Anderson Date: Thu, 18 Nov 2010 18:59:13 +0000 Subject: [PATCH] Fix an order-of-deallocation issue where the AttrListImpl could be deallocated before the global LLVMContext, causing memory errors. Patch by Peter Collingbourne. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@119721 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/VMCore/Attributes.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/VMCore/Attributes.cpp b/lib/VMCore/Attributes.cpp index 477111a3ae8..e4a228b8c62 100644 --- a/lib/VMCore/Attributes.cpp +++ b/lib/VMCore/Attributes.cpp @@ -106,6 +106,11 @@ Attributes Attribute::typeIncompatible(const Type *Ty) { // AttributeListImpl Definition //===----------------------------------------------------------------------===// +namespace llvm { + class AttributeListImpl; +} + +static ManagedStatic > AttributesLists; namespace llvm { static ManagedStatic > ALMutex; @@ -131,6 +136,8 @@ public: } void DropRef() { sys::SmartScopedLock Lock(*ALMutex); + if (!AttributesLists.isConstructed()) + return; sys::cas_flag new_val = --RefCount; if (new_val == 0) delete this; @@ -147,8 +154,6 @@ public: }; } -static ManagedStatic > AttributesLists; - AttributeListImpl::~AttributeListImpl() { // NOTE: Lock must be acquired by caller. AttributesLists->RemoveNode(this); -- 2.34.1