From a219d071ce833de7736d9ecba566be672f5da0c6 Mon Sep 17 00:00:00 2001 From: Christopher Dykes Date: Thu, 15 Jun 2017 16:51:24 -0700 Subject: [PATCH] Explicitly initialize the base class of LogStream Summary: The standard does not define that `std::ostream` should have a default constructor, so this was invalid and was an error on Windows. This explicitly initializes the base class by passing a `nullptr`. Reviewed By: simpkins Differential Revision: D5259690 fbshipit-source-id: b8914d73ff2682e1a4447b8338860259778b2247 --- folly/experimental/logging/LogStream.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/folly/experimental/logging/LogStream.cpp b/folly/experimental/logging/LogStream.cpp index 947d76d7..3bf4acf6 100644 --- a/folly/experimental/logging/LogStream.cpp +++ b/folly/experimental/logging/LogStream.cpp @@ -46,7 +46,7 @@ LogStreamBuffer::int_type LogStreamBuffer::overflow(int_type ch) { } } -LogStream::LogStream() { +LogStream::LogStream() : std::ostream(nullptr) { rdbuf(&buffer_); } -- 2.34.1