From a4ff83ab8fca56796912147a6aca32040360d157 Mon Sep 17 00:00:00 2001 From: Davide Italiano Date: Tue, 15 Sep 2015 23:35:32 +0000 Subject: [PATCH] [llvm-cxxdump] Remove duplicate code check. We already fail with 'No such file or directory' when we try to open the file -- if that doesn't exist. Also add a test to verify this behavior. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247744 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/tools/llvm-cxxdump/trivial.test | 3 +++ tools/llvm-cxxdump/llvm-cxxdump.cpp | 6 ------ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/test/tools/llvm-cxxdump/trivial.test b/test/tools/llvm-cxxdump/trivial.test index 450ed3b3780..2c36620bff2 100644 --- a/test/tools/llvm-cxxdump/trivial.test +++ b/test/tools/llvm-cxxdump/trivial.test @@ -56,3 +56,6 @@ ELF-I386: _ZTS1A: 1A ELF-I386-NEXT: _ZTV1A[0]: 0 ELF-I386-NEXT: _ZTV1A[4]: _ZTI1A ELF-I386-NEXT: _ZTV1A[8]: _ZN1A1fEv + +RUN: not llvm-cxxdump %t.blah 2>&1 | FileCheck --check-prefix=ENOENT %s +ENOENT: {{.*}}.blah: {{[Nn]}}o such file or directory diff --git a/tools/llvm-cxxdump/llvm-cxxdump.cpp b/tools/llvm-cxxdump/llvm-cxxdump.cpp index ede13f7aca5..bea34fee3aa 100644 --- a/tools/llvm-cxxdump/llvm-cxxdump.cpp +++ b/tools/llvm-cxxdump/llvm-cxxdump.cpp @@ -499,12 +499,6 @@ static void dumpArchive(const Archive *Arc) { } static void dumpInput(StringRef File) { - // If file isn't stdin, check that it exists. - if (File != "-" && !sys::fs::exists(File)) { - reportError(File, cxxdump_error::file_not_found); - return; - } - // Attempt to open the binary. ErrorOr> BinaryOrErr = createBinary(File); if (std::error_code EC = BinaryOrErr.getError()) { -- 2.34.1