From a64e4f2d3c7dda6698791564d83e13e58cb824b7 Mon Sep 17 00:00:00 2001 From: Yedidya Feldblum Date: Fri, 7 Aug 2015 12:34:34 -0700 Subject: [PATCH] Avoid incorrect constexpr in folly/AtomicHashArray.h. Summary: [Folly] Avoid incorrect constexpr in folly/AtomicHashArray.h. It's actually not transitively constexpr, because it uses const values that are not themselves constexpr. Depending on the compiler, it could theoretically fail to build. Reviewed By: @Gownta Differential Revision: D2322143 --- folly/AtomicHashArray.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/folly/AtomicHashArray.h b/folly/AtomicHashArray.h index 1142eda9..3479572d 100644 --- a/folly/AtomicHashArray.h +++ b/folly/AtomicHashArray.h @@ -134,13 +134,13 @@ class AtomicHashArray : boost::noncopyable { static const KeyT kErasedKey; public: - constexpr Config() : emptyKey(kEmptyKey), - lockedKey(kLockedKey), - erasedKey(kErasedKey), - maxLoadFactor(0.8), - growthFactor(-1), - entryCountThreadCacheSize(1000), - capacity(0) {} + Config() : emptyKey(kEmptyKey), + lockedKey(kLockedKey), + erasedKey(kErasedKey), + maxLoadFactor(0.8), + growthFactor(-1), + entryCountThreadCacheSize(1000), + capacity(0) {} }; static const Config defaultConfig; -- 2.34.1