From a9dd3713d0902dd7da43077a1271940cba24524e Mon Sep 17 00:00:00 2001 From: Colin LeMahieu Date: Thu, 18 Dec 2014 23:36:15 +0000 Subject: [PATCH] Reverting 224550, was not ready for commit. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@224552 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/Hexagon/HexagonFixupHwLoops.cpp | 4 +- lib/Target/Hexagon/HexagonHardwareLoops.cpp | 12 +- lib/Target/Hexagon/HexagonInstrInfo.cpp | 2 +- lib/Target/Hexagon/HexagonInstrInfo.td | 140 +++---------------- lib/Target/Hexagon/HexagonRegisterInfo.td | 5 - lib/Target/Hexagon/HexagonVLIWPacketizer.cpp | 4 +- test/MC/Disassembler/Hexagon/cr.txt | 20 --- 7 files changed, 33 insertions(+), 154 deletions(-) diff --git a/lib/Target/Hexagon/HexagonFixupHwLoops.cpp b/lib/Target/Hexagon/HexagonFixupHwLoops.cpp index a91c2e1a32f..209b83f56ed 100644 --- a/lib/Target/Hexagon/HexagonFixupHwLoops.cpp +++ b/lib/Target/Hexagon/HexagonFixupHwLoops.cpp @@ -81,8 +81,8 @@ FunctionPass *llvm::createHexagonFixupHwLoops() { /// \brief Returns true if the instruction is a hardware loop instruction. static bool isHardwareLoop(const MachineInstr *MI) { - return MI->getOpcode() == Hexagon::J2_loop0r || - MI->getOpcode() == Hexagon::J2_loop0i; + return MI->getOpcode() == Hexagon::LOOP0_r || + MI->getOpcode() == Hexagon::LOOP0_i; } diff --git a/lib/Target/Hexagon/HexagonHardwareLoops.cpp b/lib/Target/Hexagon/HexagonHardwareLoops.cpp index cbb80f307d2..39ed1abb5b8 100644 --- a/lib/Target/Hexagon/HexagonHardwareLoops.cpp +++ b/lib/Target/Hexagon/HexagonHardwareLoops.cpp @@ -285,8 +285,8 @@ INITIALIZE_PASS_END(HexagonHardwareLoops, "hwloops", /// \brief Returns true if the instruction is a hardware loop instruction. static bool isHardwareLoop(const MachineInstr *MI) { - return MI->getOpcode() == Hexagon::J2_loop0r || - MI->getOpcode() == Hexagon::J2_loop0i; + return MI->getOpcode() == Hexagon::LOOP0_r || + MI->getOpcode() == Hexagon::LOOP0_i; } FunctionPass *llvm::createHexagonHardwareLoops() { @@ -1086,7 +1086,7 @@ bool HexagonHardwareLoops::convertToHardwareLoop(MachineLoop *L) { BuildMI(*Preheader, InsertPos, DL, TII->get(TargetOpcode::COPY), CountReg) .addReg(TripCount->getReg(), 0, TripCount->getSubReg()); // Add the Loop instruction to the beginning of the loop. - BuildMI(*Preheader, InsertPos, DL, TII->get(Hexagon::J2_loop0r)) + BuildMI(*Preheader, InsertPos, DL, TII->get(Hexagon::LOOP0_r)) .addMBB(LoopStart) .addReg(CountReg); } else { @@ -1095,14 +1095,14 @@ bool HexagonHardwareLoops::convertToHardwareLoop(MachineLoop *L) { // if the immediate fits in the instructions. Otherwise, we need to // create a new virtual register. int64_t CountImm = TripCount->getImm(); - if (!TII->isValidOffset(Hexagon::J2_loop0i, CountImm)) { + if (!TII->isValidOffset(Hexagon::LOOP0_i, CountImm)) { unsigned CountReg = MRI->createVirtualRegister(&Hexagon::IntRegsRegClass); BuildMI(*Preheader, InsertPos, DL, TII->get(Hexagon::A2_tfrsi), CountReg) .addImm(CountImm); - BuildMI(*Preheader, InsertPos, DL, TII->get(Hexagon::J2_loop0r)) + BuildMI(*Preheader, InsertPos, DL, TII->get(Hexagon::LOOP0_r)) .addMBB(LoopStart).addReg(CountReg); } else - BuildMI(*Preheader, InsertPos, DL, TII->get(Hexagon::J2_loop0i)) + BuildMI(*Preheader, InsertPos, DL, TII->get(Hexagon::LOOP0_i)) .addMBB(LoopStart).addImm(CountImm); } diff --git a/lib/Target/Hexagon/HexagonInstrInfo.cpp b/lib/Target/Hexagon/HexagonInstrInfo.cpp index 5eb922a47c0..997a5265b2e 100644 --- a/lib/Target/Hexagon/HexagonInstrInfo.cpp +++ b/lib/Target/Hexagon/HexagonInstrInfo.cpp @@ -1172,7 +1172,7 @@ isValidOffset(const int Opcode, const int Offset) const { case Hexagon::LDriw_pred: return true; - case Hexagon::J2_loop0i: + case Hexagon::LOOP0_i: return isUInt<10>(Offset); // INLINEASM is very special. diff --git a/lib/Target/Hexagon/HexagonInstrInfo.td b/lib/Target/Hexagon/HexagonInstrInfo.td index b12fff01cae..3ac379d3155 100644 --- a/lib/Target/Hexagon/HexagonInstrInfo.td +++ b/lib/Target/Hexagon/HexagonInstrInfo.td @@ -3249,124 +3249,6 @@ def BARRIER : SYSInst<(outs), (ins), //===----------------------------------------------------------------------===// // SYSTEM/SUPER - //===----------------------------------------------------------------------===// -//===----------------------------------------------------------------------===// -// CRUSER - Type. -//===----------------------------------------------------------------------===// -// HW loop -let isExtendable = 1, isExtentSigned = 1, opExtentBits = 9, opExtentAlign = 2, - opExtendable = 0, hasSideEffects = 0 in -class LOOP_iBase - : CRInst<(outs), (ins brOp:$offset, u10Imm:$src2), - #mnemonic#"($offset, #$src2)", - [], "" , CR_tc_3x_SLOT3> { - bits<9> offset; - bits<10> src2; - - let IClass = 0b0110; - - let Inst{27-22} = 0b100100; - let Inst{21} = !if (!eq(mnemonic, "loop0"), 0b0, 0b1); - let Inst{20-16} = src2{9-5}; - let Inst{12-8} = offset{8-4}; - let Inst{7-5} = src2{4-2}; - let Inst{4-3} = offset{3-2}; - let Inst{1-0} = src2{1-0}; -} - -let isExtendable = 1, isExtentSigned = 1, opExtentBits = 9, opExtentAlign = 2, - opExtendable = 0, hasSideEffects = 0 in -class LOOP_rBase - : CRInst<(outs), (ins brOp:$offset, IntRegs:$src2), - #mnemonic#"($offset, $src2)", - [], "" ,CR_tc_3x_SLOT3> { - bits<9> offset; - bits<5> src2; - - let IClass = 0b0110; - - let Inst{27-22} = 0b000000; - let Inst{21} = !if (!eq(mnemonic, "loop0"), 0b0, 0b1); - let Inst{20-16} = src2; - let Inst{12-8} = offset{8-4}; - let Inst{4-3} = offset{3-2}; - } - -multiclass LOOP_ri { - def i : LOOP_iBase; - def r : LOOP_rBase; -} - - -let Defs = [SA0, LC0, USR], isCodeGenOnly = 0 in -defm J2_loop0 : LOOP_ri<"loop0">; - -// Interestingly only loop0's appear to set usr.lpcfg -let Defs = [SA1, LC1], isCodeGenOnly = 0 in -defm J2_loop1 : LOOP_ri<"loop1">; - -let isBranch = 1, isTerminator = 1, hasSideEffects = 0, - Defs = [PC, LC0], Uses = [SA0, LC0] in { -def ENDLOOP0 : Endloop<(outs), (ins brtarget:$offset), - ":endloop0", - []>; -} - -let isBranch = 1, isTerminator = 1, hasSideEffects = 0, - Defs = [PC, LC1], Uses = [SA1, LC1] in { -def ENDLOOP1 : Endloop<(outs), (ins brtarget:$offset), - ":endloop1", - []>; -} - -// Pipelined loop instructions, sp[123]loop0 -let Defs = [LC0, SA0, P3, USR], hasSideEffects = 0, - isExtentSigned = 1, isExtendable = 1, opExtentBits = 9, opExtentAlign = 2, - opExtendable = 0, isPredicateLate = 1 in -class SPLOOP_iBase op> - : CRInst <(outs), (ins brtarget:$r7_2, u10Imm:$U10), - "p3 = sp"#SP#"loop0($r7_2, #$U10)" > { - bits<9> r7_2; - bits<10> U10; - - let IClass = 0b0110; - - let Inst{22-21} = op; - let Inst{27-23} = 0b10011; - let Inst{20-16} = U10{9-5}; - let Inst{12-8} = r7_2{8-4}; - let Inst{7-5} = U10{4-2}; - let Inst{4-3} = r7_2{3-2}; - let Inst{1-0} = U10{1-0}; - } - -let Defs = [LC0, SA0, P3, USR], hasSideEffects = 0, - isExtentSigned = 1, isExtendable = 1, opExtentBits = 9, opExtentAlign = 2, - opExtendable = 0, isPredicateLate = 1 in -class SPLOOP_rBase op> - : CRInst <(outs), (ins brtarget:$r7_2, IntRegs:$Rs), - "p3 = sp"#SP#"loop0($r7_2, $Rs)" > { - bits<9> r7_2; - bits<5> Rs; - - let IClass = 0b0110; - - let Inst{22-21} = op; - let Inst{27-23} = 0b00001; - let Inst{20-16} = Rs; - let Inst{12-8} = r7_2{8-4}; - let Inst{4-3} = r7_2{3-2}; - } - -multiclass SPLOOP_ri op> { - def i : SPLOOP_iBase; - def r : SPLOOP_rBase; -} - -let isCodeGenOnly = 0 in { -defm J2_ploop1s : SPLOOP_ri<"1", 0b01>; -defm J2_ploop2s : SPLOOP_ri<"2", 0b10>; -defm J2_ploop3s : SPLOOP_ri<"3", 0b11>; -} // TFRI64 - assembly mapped. let isReMaterializable = 1 in @@ -3404,6 +3286,28 @@ def TFR_FI : ALU32_ri<(outs IntRegs:$dst), (ins FrameIndex:$src1), "$dst = add($src1)", [(set (i32 IntRegs:$dst), ADDRri:$src1)]>; +// +// CR - Type. +// +let hasSideEffects = 0, Defs = [SA0, LC0] in { +def LOOP0_i : CRInst<(outs), (ins brtarget:$offset, u10Imm:$src2), + "loop0($offset, #$src2)", + []>; +} + +let hasSideEffects = 0, Defs = [SA0, LC0] in { +def LOOP0_r : CRInst<(outs), (ins brtarget:$offset, IntRegs:$src2), + "loop0($offset, $src2)", + []>; +} + +let isBranch = 1, isTerminator = 1, hasSideEffects = 0, + Defs = [PC, LC0], Uses = [SA0, LC0] in { +def ENDLOOP0 : Endloop<(outs), (ins brtarget:$offset), + ":endloop0", + []>; +} + // Support for generating global address. // Taken from X86InstrInfo.td. def SDTHexagonCONST32 : SDTypeProfile<1, 1, [ diff --git a/lib/Target/Hexagon/HexagonRegisterInfo.td b/lib/Target/Hexagon/HexagonRegisterInfo.td index 3e619d0a010..98b620028c4 100644 --- a/lib/Target/Hexagon/HexagonRegisterInfo.td +++ b/lib/Target/Hexagon/HexagonRegisterInfo.td @@ -57,7 +57,6 @@ let Namespace = "Hexagon" in { def subreg_loreg : SubRegIndex<32>; def subreg_hireg : SubRegIndex<32, 32>; - def subreg_overflow : SubRegIndex<1, 0>; // Integer registers. foreach i = 0-28 in { @@ -110,10 +109,6 @@ let Namespace = "Hexagon" in { def M0 : Rc<6, "m0">, DwarfRegNum<[71]>; def M1 : Rc<7, "m1">, DwarfRegNum<[72]>; - def USR : Rc<8, "usr">, DwarfRegNum<[74]> { - let SubRegIndices = [subreg_overflow]; - let SubRegs = [USR_OVF]; - } def PC : Rc<9, "pc">, DwarfRegNum<[32]>; // is the Dwarf number correct? def GP : Rc<11, "gp">, DwarfRegNum<[33]>; // is the Dwarf number correct? } diff --git a/lib/Target/Hexagon/HexagonVLIWPacketizer.cpp b/lib/Target/Hexagon/HexagonVLIWPacketizer.cpp index 179e49630c9..9eb3bb60b35 100644 --- a/lib/Target/Hexagon/HexagonVLIWPacketizer.cpp +++ b/lib/Target/Hexagon/HexagonVLIWPacketizer.cpp @@ -382,8 +382,8 @@ static bool IsControlFlow(MachineInstr* MI) { } static bool IsLoopN(MachineInstr *MI) { - return (MI->getOpcode() == Hexagon::J2_loop0i || - MI->getOpcode() == Hexagon::J2_loop0r); + return (MI->getOpcode() == Hexagon::LOOP0_i || + MI->getOpcode() == Hexagon::LOOP0_r); } /// DoesModifyCalleeSavedReg - Returns true if the instruction modifies a diff --git a/test/MC/Disassembler/Hexagon/cr.txt b/test/MC/Disassembler/Hexagon/cr.txt index b16a7e0fcc0..9957e6fd744 100644 --- a/test/MC/Disassembler/Hexagon/cr.txt +++ b/test/MC/Disassembler/Hexagon/cr.txt @@ -4,26 +4,6 @@ # CHECK: p1 = any8(p2) 0x01 0xc0 0xa2 0x6b # CHECK: p1 = all8(p2) -0x08 0xc4 0x15 0x60 -# CHECK: loop0 -0x08 0xc4 0x35 0x60 -# CHECK: loop1 -0x68 0xc4 0x00 0x69 -# CHECK: loop0 -0x68 0xc4 0x20 0x69 -# CHECK: loop1 -0x08 0xc4 0xb5 0x60 -# CHECK: p3 = sp1loop0 -0x08 0xc4 0xd5 0x60 -# CHECK: p3 = sp2loop0 -0x08 0xc4 0xf5 0x60 -# CHECK: p3 = sp3loop0 -0xa9 0xc4 0xa0 0x69 -# CHECK: p3 = sp1loop0 -0xa9 0xc4 0xc0 0x69 -# CHECK: p3 = sp2loop0 -0xa9 0xc4 0xe0 0x69 -# CHECK: p3 = sp3loop0 0x01 0xc3 0x02 0x6b # CHECK: p1 = and(p3, p2) 0x01 0xc3 0x62 0x6b -- 2.34.1