From ad41590c484c285d7c15b5c248138dd52ce30e4a Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Wed, 3 Dec 2014 02:03:26 +0000 Subject: [PATCH] [X86][MC] Intel syntax: accept implicit memory operand sizes larger than 80. The X86AsmParser intel handling was refactored in r216481, making it try each different memory operand size to see which one matches. Operand sizes larger than 80 ("[xyz]mmword ptr") were forgotten, which led to an "invalid operand" error for code such as: movdqa [rax], xmm0 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@223187 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/X86/AsmParser/X86AsmParser.cpp | 2 +- test/MC/X86/intel-syntax-unsized-memory.s | 26 +++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 test/MC/X86/intel-syntax-unsized-memory.s diff --git a/lib/Target/X86/AsmParser/X86AsmParser.cpp b/lib/Target/X86/AsmParser/X86AsmParser.cpp index 8ef2a5558da..65ceb620f0a 100644 --- a/lib/Target/X86/AsmParser/X86AsmParser.cpp +++ b/lib/Target/X86/AsmParser/X86AsmParser.cpp @@ -2626,7 +2626,7 @@ bool X86AsmParser::MatchAndEmitIntelInstruction(SMLoc IDLoc, unsigned &Opcode, SmallVector Match; uint64_t ErrorInfoMissingFeature = 0; if (UnsizedMemOp && UnsizedMemOp->isMemUnsized()) { - static const unsigned MopSizes[] = {8, 16, 32, 64, 80}; + static const unsigned MopSizes[] = {8, 16, 32, 64, 80, 128, 256, 512}; for (unsigned Size : MopSizes) { UnsizedMemOp->Mem.Size = Size; uint64_t ErrorInfoIgnore; diff --git a/test/MC/X86/intel-syntax-unsized-memory.s b/test/MC/X86/intel-syntax-unsized-memory.s new file mode 100644 index 00000000000..3467f8fb3e8 --- /dev/null +++ b/test/MC/X86/intel-syntax-unsized-memory.s @@ -0,0 +1,26 @@ +// RUN: llvm-mc -triple x86_64-unknown-unknown -x86-asm-syntax=intel -mcpu=knl %s | FileCheck %s + +// Check that we deduce unsized memory operands in the general, unambiguous, case. +// We can't deduce xword memory operands, because there is no instruction +// unambiguously accessing 80-bit memory. + +// CHECK: movb %al, (%rax) +mov [rax], al + +// CHECK: movw %ax, (%rax) +mov [rax], ax + +// CHECK: movl %eax, (%rax) +mov [rax], eax + +// CHECK: movq %rax, (%rax) +mov [rax], rax + +// CHECK: movdqa %xmm0, (%rax) +movdqa [rax], xmm0 + +// CHECK: vmovdqa %ymm0, (%rax) +vmovdqa [rax], ymm0 + +// CHECK: vaddps (%rax), %zmm1, %zmm1 +vaddps zmm1, zmm1, [rax] -- 2.34.1