From af8df399e1e5b01691de5edf42f09d4d8b308251 Mon Sep 17 00:00:00 2001 From: "Duncan P. N. Exon Smith" Date: Fri, 24 Apr 2015 20:47:23 +0000 Subject: [PATCH] IR: Use a bitmask to access GlobalObject subclass data Make room for more than just `Function::isMaterializable()` in the `GlobalObject` subclass data bitfield. Since we're treating it like a bitfield, change `Function::Function()` to zero-out the whole thing. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@235770 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/IR/Function.h | 10 ++++++++++ lib/IR/Function.cpp | 8 +++++--- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/include/llvm/IR/Function.h b/include/llvm/IR/Function.h index a5eed9b68b0..af62476727a 100644 --- a/include/llvm/IR/Function.h +++ b/include/llvm/IR/Function.h @@ -77,6 +77,16 @@ private: * bit 3-6: CallingConvention */ + /// Bits from GlobalObject::GlobalObjectSubclassData. + enum { + /// Whether this function is materializable. + IsMaterializableBit = 1 << 0 + }; + void setGlobalObjectBit(unsigned Mask, bool Value) { + setGlobalObjectSubClassData((~Mask & getGlobalObjectSubClassData()) | + (Value ? Mask : 0u)); + } + friend class SymbolTableListTraits; void setParent(Module *parent); diff --git a/lib/IR/Function.cpp b/lib/IR/Function.cpp index d3a09348220..227dfef9e98 100644 --- a/lib/IR/Function.cpp +++ b/lib/IR/Function.cpp @@ -206,10 +206,12 @@ void Argument::removeAttr(AttributeSet AS) { //===----------------------------------------------------------------------===// bool Function::isMaterializable() const { - return getGlobalObjectSubClassData(); + return getGlobalObjectSubClassData() & IsMaterializableBit; } -void Function::setIsMaterializable(bool V) { setGlobalObjectSubClassData(V); } +void Function::setIsMaterializable(bool V) { + setGlobalObjectBit(IsMaterializableBit, V); +} LLVMContext &Function::getContext() const { return getType()->getContext(); @@ -244,7 +246,7 @@ Function::Function(FunctionType *Ty, LinkageTypes Linkage, const Twine &name, Ty(Ty) { assert(FunctionType::isValidReturnType(getReturnType()) && "invalid return type"); - setIsMaterializable(false); + setGlobalObjectSubClassData(0); SymTab = new ValueSymbolTable(); // If the function has arguments, mark them as lazily built. -- 2.34.1