From b1320cb38158aedd5b59e0e3649ce5d1e90c9776 Mon Sep 17 00:00:00 2001 From: Jim Grosbach Date: Fri, 20 Jan 2012 20:02:39 +0000 Subject: [PATCH] TblGen diagnostic for mismatched template instantiation. Providing a template argment to a non-templatized class was crashing tblgen. Add a diagnostic. For example, $ cat bug.td class A; def B : A<0> { } $ llvm-tblgen bug.td bug.td:3:11: error: template argument provided to non-template class def B : A<0> { ^ git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@148565 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/TableGen/TGParser.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/TableGen/TGParser.cpp b/lib/TableGen/TGParser.cpp index 81c68292f1b..9ed7ebbb6bd 100644 --- a/lib/TableGen/TGParser.cpp +++ b/lib/TableGen/TGParser.cpp @@ -1516,6 +1516,10 @@ std::vector TGParser::ParseValueList(Record *CurRec, Record *ArgsRec, unsigned int ArgN = 0; if (ArgsRec != 0 && EltTy == 0) { const std::vector &TArgs = ArgsRec->getTemplateArgs(); + if (!TArgs.size()) { + TokError("template argument provided to non-template class"); + return std::vector(); + } const RecordVal *RV = ArgsRec->getValue(TArgs[ArgN]); if (!RV) { errs() << "Cannot find template arg " << ArgN << " (" << TArgs[ArgN] -- 2.34.1