From bb9a22375539730d9e6d46ddd2cb1f6da78a4120 Mon Sep 17 00:00:00 2001 From: Kyle Nekritz Date: Fri, 1 Sep 2017 09:13:58 -0700 Subject: [PATCH] Deflake some AsyncSSLSocket tests. Summary: Fulfilling starts destroying the evb in another thread which races with the socket closing on the evb. Reviewed By: siyengar, ngoyal Differential Revision: D5755271 fbshipit-source-id: ace37eee63e684c97ca0fe503293eee83514e0ac --- folly/io/async/test/AsyncSSLSocketTest2.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/folly/io/async/test/AsyncSSLSocketTest2.cpp b/folly/io/async/test/AsyncSSLSocketTest2.cpp index ae9ef53f..c50b6a7d 100644 --- a/folly/io/async/test/AsyncSSLSocketTest2.cpp +++ b/folly/io/async/test/AsyncSSLSocketTest2.cpp @@ -206,13 +206,13 @@ class ConnectClient : public AsyncSocket::ConnectCallback { } void connectSuccess() noexcept override { - promise_.setValue(true); socket_.reset(); + promise_.setValue(true); } void connectErr(const AsyncSocketException& /* ex */) noexcept override { - promise_.setValue(false); socket_.reset(); + promise_.setValue(false); } void setCtx(std::shared_ptr ctx) { -- 2.34.1