From be48204a7b80917aff0bc659c75571b28fed2f24 Mon Sep 17 00:00:00 2001 From: Eric Christopher Date: Mon, 29 Jul 2013 22:24:32 +0000 Subject: [PATCH] Elaborate a bit on the type unit and ODR conditional code. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@187385 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/AsmPrinter/DwarfDebug.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/CodeGen/AsmPrinter/DwarfDebug.cpp b/lib/CodeGen/AsmPrinter/DwarfDebug.cpp index 7ba1fc187da..33d18db034d 100644 --- a/lib/CodeGen/AsmPrinter/DwarfDebug.cpp +++ b/lib/CodeGen/AsmPrinter/DwarfDebug.cpp @@ -1098,14 +1098,14 @@ void DwarfDebug::finalizeModuleInfo() { TheCU->constructContainingTypeDIEs(); } - // For types that we'd like to move to type units or ODR check go ahead - // and either move the types out or add the ODR attribute now. + // Split out type units and conditionally add an ODR tag to the split + // out type. // FIXME: Do type splitting. for (unsigned i = 0, e = TypeUnits.size(); i != e; ++i) { MD5 Hash; DIE *Die = TypeUnits[i]; - // If we're in C++ and we want to generate the hash then go ahead and do - // that now. + // If we've requested ODR hashes, the current language is C++, and the type + // isn't located inside a C++ anonymous namespace then add the attribute now. if (GenerateODRHash && CUMap.begin()->second->getLanguage() == dwarf::DW_LANG_C_plus_plus && !isContainedInAnonNamespace(Die)) -- 2.34.1