From c2a378514142a08dead206a95a967095a4e0d7eb Mon Sep 17 00:00:00 2001 From: JF Bastien Date: Wed, 23 Dec 2015 23:56:13 +0000 Subject: [PATCH] WebAssembly: remove 'external' from test Summary: Linker testing was sad at seeing an unresolved external symbol. For now don't do that: it's valid but we're not playing with multi-file linking yet, and the LLVM tests are used as hacky sanity tests for single-file linking (the GCC torture tests are much better for this purpose). Another solution would be to use '.extern' to make the intent explicit (don't simple-file link this, there's an unresolved symbol), some assemblers use '.extern' while others ignore it, so we wouldn't really be inventing anything new. Reviewers: sunfish, kripken Subscribers: jfb, llvm-commits, dschuff Differential Revision: http://reviews.llvm.org/D15753 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@256353 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/CodeGen/WebAssembly/offset-folding.ll | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/CodeGen/WebAssembly/offset-folding.ll b/test/CodeGen/WebAssembly/offset-folding.ll index 19b110fcfa8..2b4e8a90b0f 100644 --- a/test/CodeGen/WebAssembly/offset-folding.ll +++ b/test/CodeGen/WebAssembly/offset-folding.ll @@ -5,7 +5,10 @@ target datalayout = "e-p:32:32-i64:64-n32:64-S128" target triple = "wasm32-unknown-unknown" -@x = external global [0 x i32] +; FIXME: make this 'external' and make sure it still works. WebAssembly +; currently only supports linking single files, so 'external' makes +; little sense. +@x = global [0 x i32] zeroinitializer @y = global [50 x i32] zeroinitializer ; Test basic constant offsets of both defined and external symbols. -- 2.34.1