From c2e7b3e49549cc306a36a052b12b7b0fe0fb45b6 Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Thu, 12 Nov 2015 01:41:59 +0000 Subject: [PATCH] dwarfdump: Add some error handling for DWP index sections of the wrong size git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@252843 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/DebugInfo/DWARF/DWARFUnitIndex.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp b/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp index a050d82c295..0bb786d7b72 100644 --- a/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp +++ b/lib/DebugInfo/DWARF/DWARFUnitIndex.cpp @@ -16,6 +16,8 @@ namespace llvm { bool DWARFUnitIndex::Header::parse(DataExtractor IndexData, uint32_t *OffsetPtr) { + if (!IndexData.isValidOffsetForDataOfSize(*OffsetPtr, 16)) + return false; Version = IndexData.getU32(OffsetPtr); NumColumns = IndexData.getU32(OffsetPtr); NumUnits = IndexData.getU32(OffsetPtr); @@ -32,6 +34,11 @@ bool DWARFUnitIndex::parse(DataExtractor IndexData) { if (!Header.parse(IndexData, &Offset)) return false; + if (!IndexData.isValidOffsetForDataOfSize( + Offset, Header.NumBuckets * (8 + 4) + + (2 * Header.NumUnits + 1) * 4 * Header.NumColumns)) + return false; + Rows = llvm::make_unique(Header.NumBuckets); auto Contribs = llvm::make_unique(Header.NumUnits); -- 2.34.1