From c729bae7b31e63695684d58c32d49c622ec7a44f Mon Sep 17 00:00:00 2001 From: "Duncan P. N. Exon Smith" Date: Wed, 1 Oct 2014 21:14:20 +0000 Subject: [PATCH] DIBuilder: Remove dead code I neglected to update `DIBuilder::createPieceExpression()` in r218797, which I noticed while rebasing a patch for PR17891. On closer inspection, it looks like dead code. If there are any downstream users of this, you should transition to the more general `createExpression()`. Or, we can add this back, but then it should just forward to `createExpression()`. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218820 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/IR/DIBuilder.h | 8 -------- lib/IR/DIBuilder.cpp | 14 -------------- 2 files changed, 22 deletions(-) diff --git a/include/llvm/IR/DIBuilder.h b/include/llvm/IR/DIBuilder.h index d12a0c609db..3e9f43ad8a2 100644 --- a/include/llvm/IR/DIBuilder.h +++ b/include/llvm/IR/DIBuilder.h @@ -505,14 +505,6 @@ namespace llvm { /// @param Addr An array of complex address operations. DIExpression createExpression(ArrayRef Addr = None); - /// createPieceExpression - Create a descriptor to describe one part - /// of aggregate variable that is fragmented across multiple Values. - /// - /// @param OffsetInBytes Offset of the piece in bytes. - /// @param SizeInBytes Size of the piece in bytes. - DIExpression createPieceExpression(unsigned OffsetInBytes, - unsigned SizeInBytes); - /// createFunction - Create a new descriptor for the specified subprogram. /// See comments in DISubprogram for descriptions of these fields. /// @param Scope Function scope. diff --git a/lib/IR/DIBuilder.cpp b/lib/IR/DIBuilder.cpp index f1d4a21bb73..743886946fc 100644 --- a/lib/IR/DIBuilder.cpp +++ b/lib/IR/DIBuilder.cpp @@ -1056,20 +1056,6 @@ DIExpression DIBuilder::createExpression(ArrayRef Addr) { return DIExpression(MDNode::get(VMContext, Elts)); } -/// createVariablePiece - Create a descriptor to describe one part -/// of aggregate variable that is fragmented across multiple Values. -DIExpression DIBuilder::createPieceExpression(unsigned OffsetInBytes, - unsigned SizeInBytes) { - assert(SizeInBytes > 0 && "zero-size piece"); - Value *Addr[] = { - GetTagConstant(VMContext, DW_TAG_expression), - ConstantInt::get(Type::getInt64Ty(VMContext), dwarf::DW_OP_piece), - ConstantInt::get(Type::getInt64Ty(VMContext), OffsetInBytes), - ConstantInt::get(Type::getInt64Ty(VMContext), SizeInBytes)}; - - return DIExpression(MDNode::get(VMContext, Addr)); -} - /// createFunction - Create a new descriptor for the specified function. /// FIXME: this is added for dragonegg. Once we update dragonegg /// to call resolve function, this will be removed. -- 2.34.1