From c843abe868be76bb18d77ca6bda53dd4d2cf12f7 Mon Sep 17 00:00:00 2001 From: Evan Cheng Date: Thu, 24 May 2007 02:35:39 +0000 Subject: [PATCH] Fix a typo that caused combiner to create mal-formed pre-indexed store where value store is the same as the base pointer. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@37318 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/SelectionDAG/DAGCombiner.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/lib/CodeGen/SelectionDAG/DAGCombiner.cpp index 05000115417..b646f5ecdc5 100644 --- a/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -3267,12 +3267,12 @@ bool DAGCombiner::CombineToPreIndexedLoadStore(SDNode *N) { return false; // Try turning it into a pre-indexed load / store except when: - // 1) The base is a frame index. - // 2) If N is a store and the ptr is either the same as or is a + // 1) The new base ptr is a frame index. + // 2) If N is a store and the new base ptr is either the same as or is a // predecessor of the value being stored. - // 3) Another use of base ptr is a predecessor of N. If ptr is folded + // 3) Another use of old base ptr is a predecessor of N. If ptr is folded // that would create a cycle. - // 4) All uses are load / store ops that use it as base ptr. + // 4) All uses are load / store ops that use it as old base ptr. // Check #1. Preinc'ing a frame index would require copying the stack pointer // (plus the implicit offset) to a register to preinc anyway. @@ -3282,11 +3282,11 @@ bool DAGCombiner::CombineToPreIndexedLoadStore(SDNode *N) { // Check #2. if (!isLoad) { SDOperand Val = cast(N)->getValue(); - if (Val == Ptr || Ptr.Val->isPredecessor(Val.Val)) + if (Val == BasePtr || BasePtr.Val->isPredecessor(Val.Val)) return false; } - // Now check for #2 and #3. + // Now check for #3 and #4. bool RealUse = false; for (SDNode::use_iterator I = Ptr.Val->use_begin(), E = Ptr.Val->use_end(); I != E; ++I) { -- 2.34.1