From c8479b8fffbab3130d96dcb2363691bf0c8cc5c1 Mon Sep 17 00:00:00 2001 From: Benoit Goby Date: Tue, 29 May 2012 13:57:27 -0700 Subject: [PATCH] usb: gadget: android: Fix product name Product names may contain spaces and scanf %s only matches the 1st word. Use strlcpy instead. Change-Id: Ie8703fea9775f7fc17fe615a42597ca3816d36b0 Signed-off-by: Benoit Goby --- drivers/usb/gadget/android.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/usb/gadget/android.c b/drivers/usb/gadget/android.c index d2c3393237b6..7a2af5844113 100644 --- a/drivers/usb/gadget/android.c +++ b/drivers/usb/gadget/android.c @@ -1053,10 +1053,7 @@ field ## _store(struct device *dev, struct device_attribute *attr, \ { \ if (size >= sizeof(buffer)) \ return -EINVAL; \ - if (sscanf(buf, "%s", buffer) == 1) { \ - return size; \ - } \ - return -1; \ + return strlcpy(buffer, buf, sizeof(buffer)); \ } \ static DEVICE_ATTR(field, S_IRUGO | S_IWUSR, field ## _show, field ## _store); -- 2.34.1