From cba386ccac87c2446579ef235d2b4dc7951c0941 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 25 Jan 2010 20:52:54 +0000 Subject: [PATCH] remove JumpTableDirective, it is always null. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@94445 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/MC/MCAsmInfo.h | 7 +++---- lib/CodeGen/AsmPrinter/AsmPrinter.cpp | 3 ++- lib/MC/MCAsmInfo.cpp | 1 - lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp | 2 +- 4 files changed, 6 insertions(+), 7 deletions(-) diff --git a/include/llvm/MC/MCAsmInfo.h b/include/llvm/MC/MCAsmInfo.h index f499189a906..8a3ab738100 100644 --- a/include/llvm/MC/MCAsmInfo.h +++ b/include/llvm/MC/MCAsmInfo.h @@ -170,9 +170,8 @@ namespace llvm { //===--- Section Switching Directives ---------------------------------===// - /// JumpTableDirective - if non-null, the directive to emit before jump + /// PICJumpTableDirective - if non-null, the directive to emit before jump /// table entries. FIXME: REMOVE THIS. - const char *JumpTableDirective; // Defaults to NULL. const char *PICJumpTableDirective; // Defaults to NULL. @@ -374,8 +373,8 @@ namespace llvm { const char *getAscizDirective() const { return AscizDirective; } - const char *getJumpTableDirective(bool isPIC) const { - return isPIC ? PICJumpTableDirective : JumpTableDirective; + const char *getPICJumpTableDirective() const { + return PICJumpTableDirective; } const char *getAlignDirective() const { return AlignDirective; diff --git a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp index 292fcdb10c5..39712ded4c2 100644 --- a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp +++ b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp @@ -538,7 +538,8 @@ void AsmPrinter::printPICJumpTableEntry(const MachineJumpTableInfo *MJTI, // Use JumpTableDirective otherwise honor the entry size from the jump table // info. - const char *JTEntryDirective = MAI->getJumpTableDirective(isPIC); + const char *JTEntryDirective = 0; + if (isPIC) JTEntryDirective = MAI->getPICJumpTableDirective(); bool HadJTEntryDirective = JTEntryDirective != NULL; if (!HadJTEntryDirective) { JTEntryDirective = MJTI->getEntrySize() == 4 ? diff --git a/lib/MC/MCAsmInfo.cpp b/lib/MC/MCAsmInfo.cpp index c0ca7e9df9f..0f3c46ba826 100644 --- a/lib/MC/MCAsmInfo.cpp +++ b/lib/MC/MCAsmInfo.cpp @@ -48,7 +48,6 @@ MCAsmInfo::MCAsmInfo() { AlignDirective = "\t.align\t"; AlignmentIsInBytes = true; TextAlignFillValue = 0; - JumpTableDirective = 0; PICJumpTableDirective = 0; GlobalDirective = "\t.globl\t"; SetDirective = 0; diff --git a/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp b/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp index b3654971a52..44a9a28ef89 100644 --- a/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp +++ b/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp @@ -460,7 +460,7 @@ void X86AsmPrinter::printPICJumpTableSetLabel(unsigned uid, return; // We don't need .set machinery if we have GOT-style relocations - if (Subtarget->isPICStyleGOT()) + if (Subtarget->isPICStyleGOT()) // X86-32 on ELF. return; O << MAI->getSetDirective() << ' ' << MAI->getPrivateGlobalPrefix() -- 2.34.1