From cd0dcf8d4e755d32f51e66764c411bf894db6d07 Mon Sep 17 00:00:00 2001 From: Sanjay Patel Date: Mon, 28 Sep 2015 21:44:46 +0000 Subject: [PATCH] move one-use check under the comment that describes it; NFCI git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@248745 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/CodeGenPrepare.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/CodeGen/CodeGenPrepare.cpp b/lib/CodeGen/CodeGenPrepare.cpp index c667601ccf3..c69b0388471 100644 --- a/lib/CodeGen/CodeGenPrepare.cpp +++ b/lib/CodeGen/CodeGenPrepare.cpp @@ -3854,7 +3854,7 @@ static bool isFormingBranchFromSelectProfitable(SelectInst *SI) { // avoid stalls on the load from memory. If the compare has more than one use // there's probably another cmov or setcc around so it's not worth emitting a // branch. - if (!Cmp) + if (!Cmp || !Cmp->hasOneUse()) return false; Value *CmpOp0 = Cmp->getOperand(0); @@ -3862,8 +3862,7 @@ static bool isFormingBranchFromSelectProfitable(SelectInst *SI) { // We check that the memory operand has one use to avoid uses of the loaded // value directly after the compare, making branches unprofitable. - return Cmp->hasOneUse() && - ((isa(CmpOp0) && CmpOp0->hasOneUse()) || + return ((isa(CmpOp0) && CmpOp0->hasOneUse()) || (isa(CmpOp1) && CmpOp1->hasOneUse())); } -- 2.34.1