From cda985e1912d6f09a21bc84660dca4c3efdcb939 Mon Sep 17 00:00:00 2001 From: Reid Spencer Date: Wed, 15 Dec 2004 01:51:56 +0000 Subject: [PATCH] For PR351: * Remove #inclusion of FileUtilities.h, not needed any more. * Convert getUniqueFilename -> sys::Pat::makeUnique() git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18948 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Archive/ArchiveWriter.cpp | 1 - lib/Bytecode/Archive/ArchiveWriter.cpp | 1 - lib/Debugger/ProgramInfo.cpp | 1 - lib/Debugger/SourceFile.cpp | 1 - lib/Support/ToolRunner.cpp | 25 +++++++++++++++++-------- tools/bugpoint/ToolRunner.cpp | 25 +++++++++++++++++-------- 6 files changed, 34 insertions(+), 20 deletions(-) diff --git a/lib/Archive/ArchiveWriter.cpp b/lib/Archive/ArchiveWriter.cpp index 64c256718e8..58e785384cf 100644 --- a/lib/Archive/ArchiveWriter.cpp +++ b/lib/Archive/ArchiveWriter.cpp @@ -13,7 +13,6 @@ #include "ArchiveInternals.h" #include "llvm/Bytecode/Reader.h" -#include "llvm/Support/FileUtilities.h" #include "llvm/Support/Compressor.h" #include "llvm/System/Signals.h" #include diff --git a/lib/Bytecode/Archive/ArchiveWriter.cpp b/lib/Bytecode/Archive/ArchiveWriter.cpp index 64c256718e8..58e785384cf 100644 --- a/lib/Bytecode/Archive/ArchiveWriter.cpp +++ b/lib/Bytecode/Archive/ArchiveWriter.cpp @@ -13,7 +13,6 @@ #include "ArchiveInternals.h" #include "llvm/Bytecode/Reader.h" -#include "llvm/Support/FileUtilities.h" #include "llvm/Support/Compressor.h" #include "llvm/System/Signals.h" #include diff --git a/lib/Debugger/ProgramInfo.cpp b/lib/Debugger/ProgramInfo.cpp index c0d85f97e45..17175c4e4cf 100644 --- a/lib/Debugger/ProgramInfo.cpp +++ b/lib/Debugger/ProgramInfo.cpp @@ -20,7 +20,6 @@ #include "llvm/Module.h" #include "llvm/Debugger/SourceFile.h" #include "llvm/Debugger/SourceLanguage.h" -#include "llvm/Support/FileUtilities.h" #include "llvm/Support/SlowOperationInformer.h" #include "llvm/ADT/STLExtras.h" #include diff --git a/lib/Debugger/SourceFile.cpp b/lib/Debugger/SourceFile.cpp index 9dc0a9616f5..da2d3475df5 100644 --- a/lib/Debugger/SourceFile.cpp +++ b/lib/Debugger/SourceFile.cpp @@ -13,7 +13,6 @@ #include "llvm/Debugger/SourceFile.h" #include "llvm/Support/SlowOperationInformer.h" -#include "llvm/Support/FileUtilities.h" #include #include #include diff --git a/lib/Support/ToolRunner.cpp b/lib/Support/ToolRunner.cpp index fcf6608f2d8..5f6336e672f 100644 --- a/lib/Support/ToolRunner.cpp +++ b/lib/Support/ToolRunner.cpp @@ -30,7 +30,8 @@ static void ProcessFailure(std::string ProgPath, const char** Args) { OS << "\n"; // Rerun the compiler, capturing any error messages to print them. - std::string ErrorFilename = getUniqueFilename("error_messages"); + sys::Path ErrorFilename("error_messages"); + ErrorFilename.makeUnique(); RunProgramWithTimeout(ProgPath, Args, "/dev/null", ErrorFilename.c_str(), ErrorFilename.c_str()); @@ -43,7 +44,7 @@ static void ProcessFailure(std::string ProgPath, const char** Args) { ErrorFile.close(); } - removeFile(ErrorFilename); + removeFile(ErrorFilename.toString()); throw ToolExecutionError(OS.str()); } @@ -123,7 +124,9 @@ AbstractInterpreter *AbstractInterpreter::createLLI(const std::string &ProgPath, // LLC Implementation of AbstractIntepreter interface // void LLC::OutputAsm(const std::string &Bytecode, std::string &OutputAsmFile) { - OutputAsmFile = getUniqueFilename(Bytecode+".llc.s"); + sys::Path uniqueFile(Bytecode+".llc.s"); + uniqueFile.makeUnique(); + OutputAsmFile = uniqueFile.toString(); std::vector LLCArgs; LLCArgs.push_back (LLCPath.c_str()); @@ -265,7 +268,9 @@ AbstractInterpreter *AbstractInterpreter::createJIT(const std::string &ProgPath, void CBE::OutputC(const std::string &Bytecode, std::string &OutputCFile) { - OutputCFile = getUniqueFilename(Bytecode+".cbe.c"); + sys::Path uniqueFile(Bytecode+".cbe.c"); + uniqueFile.makeUnique(); + OutputCFile = uniqueFile.toString(); std::vector LLCArgs; LLCArgs.push_back (LLCPath.c_str()); @@ -361,7 +366,8 @@ int GCC::ExecuteProgram(const std::string &ProgramFile, } GCCArgs.push_back(ProgramFile.c_str()); // Specify the input filename... GCCArgs.push_back("-o"); - std::string OutputBinary = getUniqueFilename(ProgramFile+".gcc.exe"); + sys::Path OutputBinary (ProgramFile+".gcc.exe"); + OutputBinary.makeUnique(); GCCArgs.push_back(OutputBinary.c_str()); // Output to the right file... GCCArgs.push_back("-lm"); // Hard-code the math library... GCCArgs.push_back("-O2"); // Optimize the program a bit... @@ -392,14 +398,17 @@ int GCC::ExecuteProgram(const std::string &ProgramFile, std::cerr << "\n"; ); - FileRemover OutputBinaryRemover(OutputBinary); - return RunProgramWithTimeout(OutputBinary, &ProgramArgs[0], + FileRemover OutputBinaryRemover(OutputBinary.toString()); + return RunProgramWithTimeout(OutputBinary.toString(), &ProgramArgs[0], InputFile, OutputFile, OutputFile, Timeout); } int GCC::MakeSharedObject(const std::string &InputFile, FileType fileType, std::string &OutputFile) { - OutputFile = getUniqueFilename(InputFile+LTDL_SHLIB_EXT); + sys::Path uniqueFilename(InputFile+LTDL_SHLIB_EXT); + uniqueFilename.makeUnique(); + OutputFile = uniqueFilename.toString(); + // Compile the C/asm file into a shared object const char* GCCArgs[] = { GCCPath.c_str(), diff --git a/tools/bugpoint/ToolRunner.cpp b/tools/bugpoint/ToolRunner.cpp index fcf6608f2d8..5f6336e672f 100644 --- a/tools/bugpoint/ToolRunner.cpp +++ b/tools/bugpoint/ToolRunner.cpp @@ -30,7 +30,8 @@ static void ProcessFailure(std::string ProgPath, const char** Args) { OS << "\n"; // Rerun the compiler, capturing any error messages to print them. - std::string ErrorFilename = getUniqueFilename("error_messages"); + sys::Path ErrorFilename("error_messages"); + ErrorFilename.makeUnique(); RunProgramWithTimeout(ProgPath, Args, "/dev/null", ErrorFilename.c_str(), ErrorFilename.c_str()); @@ -43,7 +44,7 @@ static void ProcessFailure(std::string ProgPath, const char** Args) { ErrorFile.close(); } - removeFile(ErrorFilename); + removeFile(ErrorFilename.toString()); throw ToolExecutionError(OS.str()); } @@ -123,7 +124,9 @@ AbstractInterpreter *AbstractInterpreter::createLLI(const std::string &ProgPath, // LLC Implementation of AbstractIntepreter interface // void LLC::OutputAsm(const std::string &Bytecode, std::string &OutputAsmFile) { - OutputAsmFile = getUniqueFilename(Bytecode+".llc.s"); + sys::Path uniqueFile(Bytecode+".llc.s"); + uniqueFile.makeUnique(); + OutputAsmFile = uniqueFile.toString(); std::vector LLCArgs; LLCArgs.push_back (LLCPath.c_str()); @@ -265,7 +268,9 @@ AbstractInterpreter *AbstractInterpreter::createJIT(const std::string &ProgPath, void CBE::OutputC(const std::string &Bytecode, std::string &OutputCFile) { - OutputCFile = getUniqueFilename(Bytecode+".cbe.c"); + sys::Path uniqueFile(Bytecode+".cbe.c"); + uniqueFile.makeUnique(); + OutputCFile = uniqueFile.toString(); std::vector LLCArgs; LLCArgs.push_back (LLCPath.c_str()); @@ -361,7 +366,8 @@ int GCC::ExecuteProgram(const std::string &ProgramFile, } GCCArgs.push_back(ProgramFile.c_str()); // Specify the input filename... GCCArgs.push_back("-o"); - std::string OutputBinary = getUniqueFilename(ProgramFile+".gcc.exe"); + sys::Path OutputBinary (ProgramFile+".gcc.exe"); + OutputBinary.makeUnique(); GCCArgs.push_back(OutputBinary.c_str()); // Output to the right file... GCCArgs.push_back("-lm"); // Hard-code the math library... GCCArgs.push_back("-O2"); // Optimize the program a bit... @@ -392,14 +398,17 @@ int GCC::ExecuteProgram(const std::string &ProgramFile, std::cerr << "\n"; ); - FileRemover OutputBinaryRemover(OutputBinary); - return RunProgramWithTimeout(OutputBinary, &ProgramArgs[0], + FileRemover OutputBinaryRemover(OutputBinary.toString()); + return RunProgramWithTimeout(OutputBinary.toString(), &ProgramArgs[0], InputFile, OutputFile, OutputFile, Timeout); } int GCC::MakeSharedObject(const std::string &InputFile, FileType fileType, std::string &OutputFile) { - OutputFile = getUniqueFilename(InputFile+LTDL_SHLIB_EXT); + sys::Path uniqueFilename(InputFile+LTDL_SHLIB_EXT); + uniqueFilename.makeUnique(); + OutputFile = uniqueFilename.toString(); + // Compile the C/asm file into a shared object const char* GCCArgs[] = { GCCPath.c_str(), -- 2.34.1