From d0663f3a4e042bc421905ae72be2d4d06e7e22ab Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Thu, 12 Nov 2015 17:13:45 +0000 Subject: [PATCH] Comment update. NFC. Fix the library name. Don't duplicate the comment in the .cpp file. Don't repeat the name in the comment. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@252911 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/IR/Constant.h | 9 ++++----- lib/IR/Constants.cpp | 16 ---------------- 2 files changed, 4 insertions(+), 21 deletions(-) diff --git a/include/llvm/IR/Constant.h b/include/llvm/IR/Constant.h index bb093d7ffac..555efc41c06 100644 --- a/include/llvm/IR/Constant.h +++ b/include/llvm/IR/Constant.h @@ -92,10 +92,9 @@ public: GlobalRelocations = 2 }; - /// getRelocationInfo - This method classifies the entry according to - /// whether or not it may generate a relocation entry. This must be - /// conservative, so if it might codegen to a relocatable entry, it should say - /// so. The return values are: + /// This method classifies the entry according to whether or not it may + /// generate a relocation entry. This must be conservative, so if it might + /// codegen to a relocatable entry, it should say so. The return values are: /// /// NoRelocation: This constant pool entry is guaranteed to never have a /// relocation applied to it (because it holds a simple constant like @@ -105,7 +104,7 @@ public: /// linker will never see them. /// GlobalRelocations: This entry may have arbitrary relocations. /// - /// FIXME: This really should not be in VMCore. + /// FIXME: This really should not be in IR. PossibleRelocationsTy getRelocationInfo() const; /// getAggregateElement - For aggregates (struct/array/vector) return the diff --git a/lib/IR/Constants.cpp b/lib/IR/Constants.cpp index 74d42c71de8..bcca8a2047f 100644 --- a/lib/IR/Constants.cpp +++ b/lib/IR/Constants.cpp @@ -414,22 +414,6 @@ bool Constant::isConstantUsed() const { return false; } - - -/// getRelocationInfo - This method classifies the entry according to -/// whether or not it may generate a relocation entry. This must be -/// conservative, so if it might codegen to a relocatable entry, it should say -/// so. The return values are: -/// -/// NoRelocation: This constant pool entry is guaranteed to never have a -/// relocation applied to it (because it holds a simple constant like -/// '4'). -/// LocalRelocation: This entry has relocations, but the entries are -/// guaranteed to be resolvable by the static linker, so the dynamic -/// linker will never see them. -/// GlobalRelocations: This entry may have arbitrary relocations. -/// -/// FIXME: This really should not be in IR. Constant::PossibleRelocationsTy Constant::getRelocationInfo() const { if (const GlobalValue *GV = dyn_cast(this)) { if (GV->hasLocalLinkage() || GV->hasHiddenVisibility()) -- 2.34.1