From d63e7a1b1f5b3d4700c8e104d4b9ca6cef376a75 Mon Sep 17 00:00:00 2001
From: Christopher Dykes <cdykes@fb.com>
Date: Fri, 14 Jul 2017 15:59:17 -0700
Subject: [PATCH] Replace all includes of pthread.h with the portability header

Summary: It is a non-portable include as it is include-order sensitive.

Reviewed By: yfeldblum

Differential Revision: D5427885

fbshipit-source-id: 50850064fc8fa3ed6f8fc235f31edbda4144663c
---
 folly/experimental/symbolizer/SignalHandler.cpp | 2 +-
 folly/io/async/test/AsyncSSLSocketTest.h        | 2 +-
 folly/io/async/test/AsyncSSLSocketTest2.cpp     | 3 +--
 folly/test/ProducerConsumerQueueBenchmark.cpp   | 3 +--
 folly/test/SmallLocksTest.cpp                   | 3 +--
 5 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/folly/experimental/symbolizer/SignalHandler.cpp b/folly/experimental/symbolizer/SignalHandler.cpp
index 49fbb205..ccc7bd18 100644
--- a/folly/experimental/symbolizer/SignalHandler.cpp
+++ b/folly/experimental/symbolizer/SignalHandler.cpp
@@ -18,7 +18,6 @@
 
 #include <folly/experimental/symbolizer/SignalHandler.h>
 
-#include <pthread.h>
 #include <signal.h>
 #include <sys/types.h>
 
@@ -34,6 +33,7 @@
 #include <folly/ScopeGuard.h>
 #include <folly/experimental/symbolizer/ElfCache.h>
 #include <folly/experimental/symbolizer/Symbolizer.h>
+#include <folly/portability/PThread.h>
 #include <folly/portability/SysSyscall.h>
 #include <folly/portability/Unistd.h>
 
diff --git a/folly/io/async/test/AsyncSSLSocketTest.h b/folly/io/async/test/AsyncSSLSocketTest.h
index 103b75c1..3e400804 100644
--- a/folly/io/async/test/AsyncSSLSocketTest.h
+++ b/folly/io/async/test/AsyncSSLSocketTest.h
@@ -15,7 +15,6 @@
  */
 #pragma once
 
-#include <pthread.h>
 #include <signal.h>
 
 #include <folly/ExceptionWrapper.h>
@@ -30,6 +29,7 @@
 #include <folly/io/async/ssl/SSLErrors.h>
 #include <folly/io/async/test/TestSSLServer.h>
 #include <folly/portability/GTest.h>
+#include <folly/portability/PThread.h>
 #include <folly/portability/Sockets.h>
 #include <folly/portability/Unistd.h>
 
diff --git a/folly/io/async/test/AsyncSSLSocketTest2.cpp b/folly/io/async/test/AsyncSSLSocketTest2.cpp
index c221d5d1..f0b5dd7f 100644
--- a/folly/io/async/test/AsyncSSLSocketTest2.cpp
+++ b/folly/io/async/test/AsyncSSLSocketTest2.cpp
@@ -15,8 +15,6 @@
  */
 #include <folly/io/async/test/AsyncSSLSocketTest.h>
 
-#include <pthread.h>
-
 #include <folly/futures/Promise.h>
 #include <folly/init/Init.h>
 #include <folly/io/async/AsyncSSLSocket.h>
@@ -24,6 +22,7 @@
 #include <folly/io/async/SSLContext.h>
 #include <folly/io/async/ScopedEventBaseThread.h>
 #include <folly/portability/GTest.h>
+#include <folly/portability/PThread.h>
 
 using std::string;
 using std::vector;
diff --git a/folly/test/ProducerConsumerQueueBenchmark.cpp b/folly/test/ProducerConsumerQueueBenchmark.cpp
index 01b83d97..0ee9b884 100644
--- a/folly/test/ProducerConsumerQueueBenchmark.cpp
+++ b/folly/test/ProducerConsumerQueueBenchmark.cpp
@@ -18,8 +18,6 @@
 
 #include <folly/ProducerConsumerQueue.h>
 
-#include <pthread.h>
-
 #include <cstdio>
 #include <iostream>
 #include <thread>
@@ -28,6 +26,7 @@
 
 #include <folly/Benchmark.h>
 #include <folly/portability/GFlags.h>
+#include <folly/portability/PThread.h>
 #include <folly/stats/Histogram.h>
 #include <folly/stats/Histogram-defs.h>
 
diff --git a/folly/test/SmallLocksTest.cpp b/folly/test/SmallLocksTest.cpp
index 1e71086f..630c7c6e 100644
--- a/folly/test/SmallLocksTest.cpp
+++ b/folly/test/SmallLocksTest.cpp
@@ -16,8 +16,6 @@
 
 #include <folly/SmallLocks.h>
 
-#include <pthread.h>
-
 #include <cassert>
 #include <condition_variable>
 #include <cstdio>
@@ -29,6 +27,7 @@
 #include <folly/Random.h>
 #include <folly/portability/Asm.h>
 #include <folly/portability/GTest.h>
+#include <folly/portability/PThread.h>
 #include <folly/portability/Unistd.h>
 
 using folly::MSLGuard;
-- 
2.34.1