From d981781257155966cae1470ce40cca8702a3ca20 Mon Sep 17 00:00:00 2001 From: Sven Over Date: Sun, 25 Dec 2016 00:40:42 -0800 Subject: [PATCH] fix include dependencies in folly/stats Summary: Histogram-defs.h depends on Histogram.h, so it should include it. This missing dependency is especially annoying because users who include both Histogram.h and Histogram-defs.h will find that clang-format reorders the includes such that Histogram-defs.h will be included before Histogram.h, which breaks the build. Same for BucketedTimeSeries-defs.h and TimeseriesHistogram-defs.h. Reviewed By: pixelb Differential Revision: D4366282 fbshipit-source-id: 518ef315154c28beb091e5c097db2bec6eea3ba0 --- folly/stats/BucketedTimeSeries-defs.h | 1 + folly/stats/Histogram-defs.h | 1 + folly/stats/TimeseriesHistogram-defs.h | 3 ++- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/folly/stats/BucketedTimeSeries-defs.h b/folly/stats/BucketedTimeSeries-defs.h index bd38f6d5..c21cb5dc 100644 --- a/folly/stats/BucketedTimeSeries-defs.h +++ b/folly/stats/BucketedTimeSeries-defs.h @@ -19,6 +19,7 @@ #include #include #include +#include namespace folly { diff --git a/folly/stats/Histogram-defs.h b/folly/stats/Histogram-defs.h index 5cc62f89..f89bdf11 100644 --- a/folly/stats/Histogram-defs.h +++ b/folly/stats/Histogram-defs.h @@ -17,6 +17,7 @@ #pragma once #include +#include #include diff --git a/folly/stats/TimeseriesHistogram-defs.h b/folly/stats/TimeseriesHistogram-defs.h index 08c44e96..509273f6 100644 --- a/folly/stats/TimeseriesHistogram-defs.h +++ b/folly/stats/TimeseriesHistogram-defs.h @@ -17,9 +17,10 @@ #pragma once #include +#include #include #include -#include +#include namespace folly { -- 2.34.1