From da6efc5268958a0668806e989c1c5a1f788543e5 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Thu, 25 Oct 2007 19:49:32 +0000 Subject: [PATCH] Changed XXX to FIXME, and added comment to the README file git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43359 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/BranchFolding.cpp | 2 +- lib/CodeGen/README.txt | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/CodeGen/BranchFolding.cpp b/lib/CodeGen/BranchFolding.cpp index 021001d15fc..d4b1e90fd54 100644 --- a/lib/CodeGen/BranchFolding.cpp +++ b/lib/CodeGen/BranchFolding.cpp @@ -272,7 +272,7 @@ static unsigned ComputeCommonTailLength(MachineBasicBlock *MBB1, while (I1 != MBB1->begin() && I2 != MBB2->begin()) { --I1; --I2; if (!I1->isIdenticalTo(I2) || - // XXX: This check is dubious. It's used to get around a problem where + // FIXME: This check is dubious. It's used to get around a problem where // people incorrectly expect inline asm directives to remain in the same // relative order. This is untenable because normal compiler // optimizations (like this one) may reorder and/or merge these diff --git a/lib/CodeGen/README.txt b/lib/CodeGen/README.txt index 1e2837580ac..fc59cdf8640 100644 --- a/lib/CodeGen/README.txt +++ b/lib/CodeGen/README.txt @@ -179,3 +179,11 @@ work. The ocaml frametable structure supports liveness information. It would be good to support it. + +//===---------------------------------------------------------------------===// + +The FIXME in ComputeCommonTailLength in BranchFolding.cpp needs to be +revisited. The check is there to work around a misuse of directives in inline +assembly. + +//===---------------------------------------------------------------------===// -- 2.34.1