From de0132453e2939488c2d69290bfdfb2cde94a0af Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 8 Aug 2005 17:25:38 +0000 Subject: [PATCH] Reject command lines that have too many positional arguments passed (e.g., 'opt x y'). This fixes PR493. Patch contributed by Owen Anderson! git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@22705 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/CommandLine.cpp | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/lib/Support/CommandLine.cpp b/lib/Support/CommandLine.cpp index e0a8e4d51b1..09038d3a5f3 100644 --- a/lib/Support/CommandLine.cpp +++ b/lib/Support/CommandLine.cpp @@ -297,6 +297,10 @@ void cl::ParseCommandLineOptions(int &argc, char **argv, // Check out the positional arguments to collect information about them. unsigned NumPositionalRequired = 0; + + // Determine whether or not there are an unlimited number of positionals + bool HasUnlimitedPositionals = false; + Option *ConsumeAfterOpt = 0; if (!PositionalOpts.empty()) { if (PositionalOpts[0]->getNumOccurrencesFlag() == cl::ConsumeAfter) { @@ -331,6 +335,10 @@ void cl::ParseCommandLineOptions(int &argc, char **argv, " does not require a value!"); } UnboundedFound |= EatsUnboundedNumberOfValues(Opt); + + if (Opt->getNumOccurrencesFlag() == cl::ZeroOrMore + || Opt->getNumOccurrencesFlag() == cl::OneOrMore) + HasUnlimitedPositionals = true; } } @@ -484,7 +492,13 @@ void cl::ParseCommandLineOptions(int &argc, char **argv, << "Must specify at least " << NumPositionalRequired << " positional arguments: See: " << argv[0] << " --help\n"; ErrorParsing = true; - + } else if (!HasUnlimitedPositionals + && PositionalVals.size() > PositionalOpts.size()) { + std::cerr << ProgramName + << ": Too many positional arguments specified!\n" + << "Can specify at most " << PositionalOpts.size() + << " positional arguments: See: " << argv[0] << " --help\n"; + ErrorParsing = true; } else if (ConsumeAfterOpt == 0) { // Positional args have already been handled if ConsumeAfter is specified... -- 2.34.1