From e1167f1319272e3a4d288cc1fa13c47f6d86df23 Mon Sep 17 00:00:00 2001 From: Eric Fiselier Date: Sat, 16 Aug 2014 02:16:25 +0000 Subject: [PATCH] [LIT] Move display of unsupported and xfail tests to summary. Summary: This patch changes the way xfail and unsupported tests are displayed. This output is only displayed when the --show-unsupported/--show-xfail flags are passed to lit. Currently xfail/unsupported tests are printed during the run of the test-suite. I think its better to display this information during the summary instead. This patch removes the printing of these tests from when they are run to the summary. Reviewers: ddunbar, EricWF Reviewed By: EricWF Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D4842 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@215809 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/lit/lit/main.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/utils/lit/lit/main.py b/utils/lit/lit/main.py index 2ec14e5e5df..7343d242cba 100755 --- a/utils/lit/lit/main.py +++ b/utils/lit/lit/main.py @@ -43,8 +43,6 @@ class TestingProgressDisplay(object): test.getFullName()) shouldShow = test.result.code.isFailure or \ - (self.opts.show_unsupported and test.result.code.name == 'UNSUPPORTED') or \ - (self.opts.show_xfail and test.result.code.name == 'XFAIL') or \ (not self.opts.quiet and not self.opts.succinct) if not shouldShow: return @@ -391,7 +389,12 @@ def main(builtinParameters = {}): # Print each test in any of the failing groups. for title,code in (('Unexpected Passing Tests', lit.Test.XPASS), ('Failing Tests', lit.Test.FAIL), - ('Unresolved Tests', lit.Test.UNRESOLVED)): + ('Unresolved Tests', lit.Test.UNRESOLVED), + ('Unsupported Tests', lit.Test.UNSUPPORTED), + ('Expected Failing Tests', lit.Test.XFAIL)): + if (lit.Test.XFAIL == code and not opts.show_xfail) or \ + (lit.Test.UNSUPPORTED == code and not opts.show_unsupported): + continue elts = byCode.get(code) if not elts: continue @@ -412,7 +415,7 @@ def main(builtinParameters = {}): ('Unsupported Tests ', lit.Test.UNSUPPORTED), ('Unresolved Tests ', lit.Test.UNRESOLVED), ('Unexpected Passes ', lit.Test.XPASS), - ('Unexpected Failures', lit.Test.FAIL),): + ('Unexpected Failures', lit.Test.FAIL)): if opts.quiet and not code.isFailure: continue N = len(byCode.get(code,[])) -- 2.34.1