From e3b54e2e503d1ef8f9d9abc636affa1081234c51 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Tue, 7 Jan 2014 19:38:47 +0000 Subject: [PATCH] Don't assert with private type info variables. With the gnu objc runtime private strings are used. Since we only need to produce a unique label, the fix is to just drop the asserts. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@198701 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/TargetLoweringObjectFile.cpp | 3 --- test/CodeGen/X86/catch.ll | 21 +++++++++++++++++++++ 2 files changed, 21 insertions(+), 3 deletions(-) create mode 100644 test/CodeGen/X86/catch.ll diff --git a/lib/Target/TargetLoweringObjectFile.cpp b/lib/Target/TargetLoweringObjectFile.cpp index a895dda059f..6060ac57596 100644 --- a/lib/Target/TargetLoweringObjectFile.cpp +++ b/lib/Target/TargetLoweringObjectFile.cpp @@ -111,9 +111,6 @@ MCSymbol *TargetLoweringObjectFile::getSymbol(Mangler &M, MCSymbol *TargetLoweringObjectFile::getSymbolWithGlobalValueBase( Mangler &M, const GlobalValue *GV, StringRef Suffix) const { assert(!Suffix.empty()); - assert(!GV->hasPrivateLinkage()); - assert(!GV->hasLinkerPrivateLinkage()); - assert(!GV->hasLinkerPrivateWeakLinkage()); SmallString<60> NameStr; NameStr += DL->getPrivateGlobalPrefix(); diff --git a/test/CodeGen/X86/catch.ll b/test/CodeGen/X86/catch.ll new file mode 100644 index 00000000000..6f7021360e1 --- /dev/null +++ b/test/CodeGen/X86/catch.ll @@ -0,0 +1,21 @@ +; RUN: llc < %s -mtriple=x86_64-pc-linux -relocation-model=pic | FileCheck %s + +; PR18390 +; We used to assert creating this label. The name itself is not critical. It +; just needs to be a unique local symbol. +; CHECK: .L.Lstr.DW.stub: +; CHECK-NEXT: .quad .Lstr + +@str = private unnamed_addr constant [12 x i8] c"NSException\00" +define void @f() { + invoke void @g() + to label %invoke.cont unwind label %lpad +invoke.cont: + ret void +lpad: + %tmp14 = landingpad { i8*, i32 } personality i8* bitcast (void ()* @h to i8*) + catch i8* getelementptr inbounds ([12 x i8]* @str, i64 0, i64 0) + ret void +} +declare void @g() +declare void @h() -- 2.34.1