From e3f67e10426465a302ab05cc05448f74ebc70e43 Mon Sep 17 00:00:00 2001 From: Andrii Grynenko Date: Wed, 14 Dec 2016 20:06:38 -0800 Subject: [PATCH] Require runBeforeLoop callbacks to be canceled prior to EventBase destruction Summary: This makes it similar to other other events registered with EventBase. Reviewed By: yfeldblum Differential Revision: D4331277 fbshipit-source-id: 5d728d4ae5faff1a72ed724b4e2a6c0dd6c3b02d --- folly/io/async/EventBase.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/folly/io/async/EventBase.cpp b/folly/io/async/EventBase.cpp index d3eab70c..0f09c695 100644 --- a/folly/io/async/EventBase.cpp +++ b/folly/io/async/EventBase.cpp @@ -171,9 +171,7 @@ EventBase::~EventBase() { clearCobTimeouts(); - while (!runBeforeLoopCallbacks_.empty()) { - delete &runBeforeLoopCallbacks_.front(); - } + DCHECK_EQ(0, runBeforeLoopCallbacks_.size()); (void)runLoopCallbacks(); -- 2.34.1