From e6a9d0cc99a8e77c020dc7d7f1058bf76e93902c Mon Sep 17 00:00:00 2001 From: Nick Pelly Date: Thu, 19 Aug 2010 19:27:10 -0700 Subject: [PATCH] mdm6600: Don't panic on wrong port. Lack of power management on the mdm6600 driver causes it to sometimes open with a bad port after USB re-unemeration. WARN_ON_ONCE instead of BUG_ON. Change-Id: Iae6c7aa2c1f2b30ff879a1b744a5efeef01664f9 Signed-off-by: Nick Pelly --- drivers/usb/serial/mdm6600.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/serial/mdm6600.c b/drivers/usb/serial/mdm6600.c index 6b03d86f4d04..3a1f32db30c4 100644 --- a/drivers/usb/serial/mdm6600.c +++ b/drivers/usb/serial/mdm6600.c @@ -227,12 +227,12 @@ static int mdm6600_open(struct tty_struct *tty, struct usb_serial_port *port) dbg("%s: port %d", __func__, port->number); - BUG_ON(modem->port != port); + WARN_ON_ONCE(modem->port != port); modem->tiocm_status = 0; if (port->number == MODEM_INTERFACE_NUM) { - BUG_ON(!port->interrupt_in_urb); + WARN_ON_ONCE(!port->interrupt_in_urb); rc = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL); if (rc) { dev_err(&port->dev, -- 2.34.1