From f111309c6a051f3fa6b48f9f5e372faba118b601 Mon Sep 17 00:00:00 2001 From: Xu Jianqun Date: Thu, 4 May 2017 11:16:52 +0800 Subject: [PATCH] mailbox: rk3368: fix error setting if mbox_msg is null Fix the error dump: [19252.682822] Unable to handle kernel NULL pointer dereference at virtual address 00000020 [19252.682834] pgd = ffffff800935d000 [19252.682844] [00000020] *pgd=0000000077ffe003, *pud=0000000077ffe003, *pmd=0000000000000000 [19252.682852] Internal error: Oops: 96000005 [#1] PREEMPT SMP [19252.682863] Modules linked in: pvrsrvkm(O) [19252.682872] CPU: 1 PID: 59 Comm: irq/32-ff6b0000 Tainted: G W O 4.4.55 #34 [19252.682875] Hardware name: Rockchip rk3368 p9 board (DT) [19252.682880] task: ffffffc074cf8c40 ti: ffffffc074d04000 task.ti: ffffffc074d04000 [19252.682894] PC is at mbox_chan_received_data+0xc/0x20 [19252.682901] LR is at rk3368_mbox_isr+0xb0/0xd0 Change-Id: I1873d6a7e7d1390d2c2c44a77c120d1a02614fdc Signed-off-by: Xu Jianqun --- drivers/mailbox/rk3368-mailbox.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mailbox/rk3368-mailbox.c b/drivers/mailbox/rk3368-mailbox.c index 03f3a74d4623..f006a546f51f 100644 --- a/drivers/mailbox/rk3368-mailbox.c +++ b/drivers/mailbox/rk3368-mailbox.c @@ -165,7 +165,6 @@ static irqreturn_t rk3368_mbox_isr(int irq, void *dev_id) msg->rx_size); mbox_chan_received_data(&mb->mbox.chans[idx], msg); - mb->chans[idx].msg = NULL; dev_dbg(mb->mbox.dev, "Chan[%d]: B2A message, cmd 0x%08x\n", idx, msg->cmd); -- 2.34.1