From f212856e5032c8ee760f6bb67190da01db296535 Mon Sep 17 00:00:00 2001 From: Owen Anderson Date: Mon, 2 Mar 2015 06:00:02 +0000 Subject: [PATCH] Teach DataLayout that zero-byte pointer sizes don't make sense. Previously this would result in assertion failures or simply crashes at various points in the optimizer when trying to create types of zero bit width. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@230936 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/IR/DataLayout.cpp | 2 ++ test/Assembler/invalid-datalayout19.ll | 6 ++++++ 2 files changed, 8 insertions(+) create mode 100644 test/Assembler/invalid-datalayout19.ll diff --git a/lib/IR/DataLayout.cpp b/lib/IR/DataLayout.cpp index 9c1dee0cfb7..c414e80f410 100644 --- a/lib/IR/DataLayout.cpp +++ b/lib/IR/DataLayout.cpp @@ -259,6 +259,8 @@ void DataLayout::parseSpecifier(StringRef Desc) { "Missing size specification for pointer in datalayout string"); Split = split(Rest, ':'); unsigned PointerMemSize = inBytes(getInt(Tok)); + if (!PointerMemSize) + report_fatal_error("Invalid pointer size of 0 bytes"); // ABI alignment. if (Rest.empty()) diff --git a/test/Assembler/invalid-datalayout19.ll b/test/Assembler/invalid-datalayout19.ll new file mode 100644 index 00000000000..fc0fc468520 --- /dev/null +++ b/test/Assembler/invalid-datalayout19.ll @@ -0,0 +1,6 @@ +; RUN: not llvm-as < %s 2>&1 | FileCheck %s + +target datalayout = "p:0:32:32" + +; CHECK: Invalid pointer size of 0 bytes + -- 2.34.1