From f28bf6c7aa9e5e2194b4e228728740f438d6f6df Mon Sep 17 00:00:00 2001 From: "Duncan P. N. Exon Smith" Date: Sat, 7 Feb 2015 01:07:30 +0000 Subject: [PATCH 1/1] Support: Fix tests for VirtualityString Since these `dwarf` functions return `const char *`, the tests need to use `StringRef` for checks. Should fix, e.g., hexagon [1]. [1]: http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/22435 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@228478 91177308-0d34-0410-b5e6-96231b3b80d8 --- unittests/Support/DwarfTest.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/unittests/Support/DwarfTest.cpp b/unittests/Support/DwarfTest.cpp index dfdf5a26a09..5352982aa13 100644 --- a/unittests/Support/DwarfTest.cpp +++ b/unittests/Support/DwarfTest.cpp @@ -96,13 +96,16 @@ TEST(DwarfTest, getAttributeEncoding) { } TEST(DwarfTest, VirtualityString) { - EXPECT_EQ("DW_VIRTUALITY_none", VirtualityString(DW_VIRTUALITY_none)); - EXPECT_EQ("DW_VIRTUALITY_virtual", VirtualityString(DW_VIRTUALITY_virtual)); - EXPECT_EQ("DW_VIRTUALITY_pure_virtual", + EXPECT_EQ(StringRef("DW_VIRTUALITY_none"), + VirtualityString(DW_VIRTUALITY_none)); + EXPECT_EQ(StringRef("DW_VIRTUALITY_virtual"), + VirtualityString(DW_VIRTUALITY_virtual)); + EXPECT_EQ(StringRef("DW_VIRTUALITY_pure_virtual"), VirtualityString(DW_VIRTUALITY_pure_virtual)); // DW_VIRTUALITY_max should be pure virtual. - EXPECT_EQ("DW_VIRTUALITY_pure_virtual", VirtualityString(DW_VIRTUALITY_max)); + EXPECT_EQ(StringRef("DW_VIRTUALITY_pure_virtual"), + VirtualityString(DW_VIRTUALITY_max)); // Invalid numbers shouldn't be stringified. EXPECT_EQ(nullptr, VirtualityString(DW_VIRTUALITY_max + 1)); -- 2.34.1