From f64159c8402ef17d14b5f7555378b2c321a4a5ab Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Wed, 3 Feb 2010 01:46:05 +0000 Subject: [PATCH] privatize a bunch of methods and move \n printing into them. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@95186 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/CodeGen/AsmPrinter.h | 12 +++++++----- lib/CodeGen/AsmPrinter/AsmPrinter.cpp | 14 ++++++-------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/include/llvm/CodeGen/AsmPrinter.h b/include/llvm/CodeGen/AsmPrinter.h index 24021cdb0f3..55b3082d0d6 100644 --- a/include/llvm/CodeGen/AsmPrinter.h +++ b/include/llvm/CodeGen/AsmPrinter.h @@ -307,7 +307,6 @@ namespace llvm { /// printLabel - This method prints a local label used by debug and /// exception handling tables. - void printLabel(const MachineInstr *MI) const; void printLabel(unsigned Id) const; /// printDeclare - This method prints a local variable declaration used by @@ -366,10 +365,17 @@ namespace llvm { virtual void EmitMachineConstantPoolValue(MachineConstantPoolValue *MCPV); + /// printOffset - This is just convenient handler for printing offsets. + void printOffset(int64_t Offset) const; + + private: + /// processDebugLoc - Processes the debug information of each machine /// instruction's DebugLoc. void processDebugLoc(const MachineInstr *MI, bool BeforePrintingInsn); + void printLabelInst(const MachineInstr *MI) const; + /// printInlineAsm - This method formats and prints the specified machine /// instruction that is an inline asm. void printInlineAsm(const MachineInstr *MI) const; @@ -381,10 +387,6 @@ namespace llvm { /// printKill - This method prints the specified kill machine instruction. void printKill(const MachineInstr *MI) const; - /// printOffset - This is just convenient handler for printing offsets. - void printOffset(int64_t Offset) const; - - private: /// EmitVisibility - This emits visibility information about symbol, if /// this is suported by the target. void EmitVisibility(MCSymbol *Sym, unsigned Visibility) const; diff --git a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp index 3358d04fc29..9844571f96e 100644 --- a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp +++ b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp @@ -350,20 +350,16 @@ void AsmPrinter::EmitFunctionBody() { case TargetInstrInfo::DBG_LABEL: case TargetInstrInfo::EH_LABEL: case TargetInstrInfo::GC_LABEL: - printLabel(II); - O << '\n'; + printLabelInst(II); break; case TargetInstrInfo::INLINEASM: printInlineAsm(II); - O << '\n'; break; case TargetInstrInfo::IMPLICIT_DEF: printImplicitDef(II); - O << '\n'; break; case TargetInstrInfo::KILL: printKill(II); - O << '\n'; break; default: EmitInstruction(II); @@ -1429,7 +1425,7 @@ void AsmPrinter::printInlineAsm(const MachineInstr *MI) const { } } } - O << "\n\t" << MAI->getCommentString() << MAI->getInlineAsmEnd(); + O << "\n\t" << MAI->getCommentString() << MAI->getInlineAsmEnd() << '\n'; } /// printImplicitDef - This method prints the specified machine instruction @@ -1438,7 +1434,7 @@ void AsmPrinter::printImplicitDef(const MachineInstr *MI) const { if (!VerboseAsm) return; O.PadToColumn(MAI->getCommentColumn()); O << MAI->getCommentString() << " implicit-def: " - << TRI->getName(MI->getOperand(0).getReg()); + << TRI->getName(MI->getOperand(0).getReg()) << '\n'; } void AsmPrinter::printKill(const MachineInstr *MI) const { @@ -1450,12 +1446,14 @@ void AsmPrinter::printKill(const MachineInstr *MI) const { assert(op.isReg() && "KILL instruction must have only register operands"); O << ' ' << TRI->getName(op.getReg()) << (op.isDef() ? "" : ""); } + O << '\n'; } /// printLabel - This method prints a local label used by debug and /// exception handling tables. -void AsmPrinter::printLabel(const MachineInstr *MI) const { +void AsmPrinter::printLabelInst(const MachineInstr *MI) const { printLabel(MI->getOperand(0).getImm()); + O << '\n'; } void AsmPrinter::printLabel(unsigned Id) const { -- 2.34.1