From f8083b7f20e0985b3c1848d25a56b1f527c0a255 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 19 Jul 2004 00:55:35 +0000 Subject: [PATCH] Method now returns null, dtor is inlined git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@14983 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/VMCore/Globals.cpp | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/lib/VMCore/Globals.cpp b/lib/VMCore/Globals.cpp index e35d801f8a5..ea877010114 100644 --- a/lib/VMCore/Globals.cpp +++ b/lib/VMCore/Globals.cpp @@ -50,25 +50,15 @@ static bool removeDeadConstantUsers(Constant* C) { /// This function returns true if the global value is now dead. If all /// users of this global are not dead, this method may return false and /// leave some of them around. -bool GlobalValue::removeDeadConstantUsers() { +void GlobalValue::removeDeadConstantUsers() { while(!use_empty()) { if (Constant* User = dyn_cast(use_back())) { if (!::removeDeadConstantUsers(User)) - return false; // Constant wasn't dead + return; // Constant wasn't dead } else { - return false; // Non-constant usage; + return; // Non-constant usage; } } - return true; -} - -/// This virtual destructor is responsible for deleting any transitively dead -/// Constants that are using the GlobalValue. -GlobalValue::~GlobalValue() { - // Its an error to attempt destruction with non-constant uses remaining. - bool okay_to_destruct = removeDeadConstantUsers(); - assert(okay_to_destruct && - "Can't destroy GlobalValue with non-constant uses."); } /// Override destroyConstant to make sure it doesn't get called on -- 2.34.1