From f94f8dcda71b0069f9dbde979a81a58a49194ba2 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sat, 3 Apr 2010 22:01:50 +0000 Subject: [PATCH] start moving towards emitting inline asm statements with EmitInlineAsm. However, this attempt is foiled by operands being emitted directly to "O" so I'll have to do some surgery and finish MCizing the world. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@100291 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/CodeGen/AsmPrinter.h | 2 +- lib/CodeGen/AsmPrinter/AsmPrinter.cpp | 44 +++++++++++++++++++++------ 2 files changed, 36 insertions(+), 10 deletions(-) diff --git a/include/llvm/CodeGen/AsmPrinter.h b/include/llvm/CodeGen/AsmPrinter.h index 51f55109c9c..93dc97b94e5 100644 --- a/include/llvm/CodeGen/AsmPrinter.h +++ b/include/llvm/CodeGen/AsmPrinter.h @@ -359,7 +359,7 @@ namespace llvm { private: /// EmitInlineAsm - Emit a blob of inline asm to the output streamer. - void EmitInlineAsm(StringRef Str); + void EmitInlineAsm(StringRef Str) const; /// processDebugLoc - Processes the debug information of each machine /// instruction's DebugLoc. diff --git a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp index 0d6a2e2999b..5e0d0dc5006 100644 --- a/lib/CodeGen/AsmPrinter/AsmPrinter.cpp +++ b/lib/CodeGen/AsmPrinter/AsmPrinter.cpp @@ -878,7 +878,7 @@ void AsmPrinter::EmitXXStructorList(Constant *List) { } /// EmitInlineAsm - Emit a blob of inline asm to the output streamer. -void AsmPrinter::EmitInlineAsm(StringRef Str) { +void AsmPrinter::EmitInlineAsm(StringRef Str) const { assert(!Str.empty() && "Can't emit empty inline asm block"); // If the output streamer is actually a .s file, just emit the blob textually. @@ -1366,9 +1366,11 @@ void AsmPrinter::processDebugLoc(const MachineInstr *MI, /// printInlineAsm - This method formats and prints the specified machine /// instruction that is an inline asm. void AsmPrinter::printInlineAsm(const MachineInstr *MI) const { + assert(MI->isInlineAsm() && "printInlineAsm only works on inline asms"); + unsigned NumOperands = MI->getNumOperands(); - // Count the number of register definitions. + // Count the number of register definitions to find the asm string. unsigned NumDefs = 0; for (; MI->getOperand(NumDefs).isReg() && MI->getOperand(NumDefs).isDef(); ++NumDefs) @@ -1379,17 +1381,32 @@ void AsmPrinter::printInlineAsm(const MachineInstr *MI) const { // Disassemble the AsmStr, printing out the literal pieces, the operands, etc. const char *AsmStr = MI->getOperand(NumDefs).getSymbolName(); - O << '\t'; - // If this asmstr is empty, just print the #APP/#NOAPP markers. // These are useful to see where empty asm's wound up. if (AsmStr[0] == 0) { - O << MAI->getCommentString() << MAI->getInlineAsmStart() << "\n\t"; - O << MAI->getCommentString() << MAI->getInlineAsmEnd() << '\n'; + if (!OutStreamer.hasRawTextSupport()) return; + + OutStreamer.EmitRawText(std::string("\t")+MAI->getCommentString()+ + MAI->getInlineAsmStart()); + OutStreamer.EmitRawText(std::string("\t")+MAI->getCommentString()+ + MAI->getInlineAsmEnd()); return; } + + // Emit the #APP start marker. This has to happen even if verbose-asm isn't + // enabled, so we use EmitRawText. + if (OutStreamer.hasRawTextSupport()) + OutStreamer.EmitRawText(std::string("\t")+MAI->getCommentString()+ + MAI->getInlineAsmStart()); + + // Emit the inline asm to a temporary string so we can emit it through + // EmitInlineAsm. +#if 0 + SmallString<256> StringData; + raw_svector_ostream O(StringData); +#endif - O << MAI->getCommentString() << MAI->getInlineAsmStart() << "\n\t"; + O << '\t'; // The variant of the current asmprinter. int AsmPrinterVariant = MAI->getAssemblerDialect(); @@ -1558,8 +1575,17 @@ void AsmPrinter::printInlineAsm(const MachineInstr *MI) const { } } } - O << "\n\t" << MAI->getCommentString() << MAI->getInlineAsmEnd(); - OutStreamer.AddBlankLine(); + O << "\n"; + +#if 0 + EmitInlineAsm(O.str()); +#endif + + // Emit the #NOAPP end marker. This has to happen even if verbose-asm isn't + // enabled, so we use EmitRawText. + if (OutStreamer.hasRawTextSupport()) + OutStreamer.EmitRawText(std::string("\t")+MAI->getCommentString()+ + MAI->getInlineAsmEnd()); } /// printImplicitDef - This method prints the specified machine instruction -- 2.34.1