From f9908172e980aab15a36bd110ccdbc5f7afa44f6 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 27 Nov 2006 04:39:56 +0000 Subject: [PATCH] If a brcond condition is promoted, make sure to zero extend it, even if not expanded into BR_CC. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@31932 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/SelectionDAG/LegalizeDAG.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp b/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp index 59f476792a0..a1a595526ba 100644 --- a/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp +++ b/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp @@ -1302,6 +1302,12 @@ SDOperand SelectionDAGLegalize::LegalizeOp(SDOperand Op) { break; case Promote: Tmp2 = PromoteOp(Node->getOperand(1)); // Promote the condition. + + // The top bits of the promoted condition are not necessarily zero, ensure + // that the value is properly zero extended. + if (!TLI.MaskedValueIsZero(Tmp2, + MVT::getIntVTBitMask(Tmp2.getValueType())^1)) + Tmp2 = DAG.getZeroExtendInReg(Tmp2, MVT::i1); break; } @@ -1323,12 +1329,6 @@ SDOperand SelectionDAGLegalize::LegalizeOp(SDOperand Op) { Tmp2.getOperand(0), Tmp2.getOperand(1), Node->getOperand(2)); } else { - // Make sure the condition is either zero or one. It may have been - // promoted from something else. - unsigned NumBits = MVT::getSizeInBits(Tmp2.getValueType()); - if (!TLI.MaskedValueIsZero(Tmp2, (~0ULL >> (64-NumBits))^1)) - Tmp2 = DAG.getZeroExtendInReg(Tmp2, MVT::i1); - Result = DAG.getNode(ISD::BR_CC, MVT::Other, Tmp1, DAG.getCondCode(ISD::SETNE), Tmp2, DAG.getConstant(0, Tmp2.getValueType()), -- 2.34.1