From fe731214d2529f7b30527fc312964af411867dd0 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Tue, 13 Sep 2011 20:50:54 +0000 Subject: [PATCH] Error out on CodeGen of unaligned load/store. Fix test so it isn't accidentally testing that case. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@139641 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp | 11 +++++++++-- test/CodeGen/X86/atomic-load-store-wide.ll | 4 ++-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp index e0c0fc255cc..4c58fe92266 100644 --- a/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp +++ b/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp @@ -3402,6 +3402,9 @@ void SelectionDAGBuilder::visitAtomicLoad(const LoadInst &I) { EVT VT = EVT::getEVT(I.getType()); + if (I.getAlignment() * 8 != VT.getSizeInBits()) + report_fatal_error("Cannot generate unaligned atomic load"); + SDValue L = DAG.getAtomic(ISD::ATOMIC_LOAD, dl, VT, VT, InChain, getValue(I.getPointerOperand()), @@ -3427,13 +3430,17 @@ void SelectionDAGBuilder::visitAtomicStore(const StoreInst &I) { SDValue InChain = getRoot(); + EVT VT = EVT::getEVT(I.getValueOperand()->getType()); + + if (I.getAlignment() * 8 != VT.getSizeInBits()) + report_fatal_error("Cannot generate unaligned atomic store"); + if (TLI.getInsertFencesForAtomic()) InChain = InsertFenceForAtomic(InChain, Order, Scope, true, dl, DAG, TLI); SDValue OutChain = - DAG.getAtomic(ISD::ATOMIC_STORE, dl, - getValue(I.getValueOperand()).getValueType().getSimpleVT(), + DAG.getAtomic(ISD::ATOMIC_STORE, dl, VT, InChain, getValue(I.getPointerOperand()), getValue(I.getValueOperand()), diff --git a/test/CodeGen/X86/atomic-load-store-wide.ll b/test/CodeGen/X86/atomic-load-store-wide.ll index 227883e5592..a9ebfef2ebe 100644 --- a/test/CodeGen/X86/atomic-load-store-wide.ll +++ b/test/CodeGen/X86/atomic-load-store-wide.ll @@ -7,13 +7,13 @@ define void @test1(i64* %ptr, i64 %val1) { ; CHECK: test1 ; CHECK: cmpxchg8b ; CHECK-NEXT: jne - store atomic i64 %val1, i64* %ptr seq_cst, align 4 + store atomic i64 %val1, i64* %ptr seq_cst, align 8 ret void } define i64 @test2(i64* %ptr) { ; CHECK: test2 ; CHECK: cmpxchg8b - %val = load atomic i64* %ptr seq_cst, align 4 + %val = load atomic i64* %ptr seq_cst, align 8 ret i64 %val } -- 2.34.1