From ff76c3292a2c6858e02ed20d756fa0e0a998a4a0 Mon Sep 17 00:00:00 2001
From: Yuri Putivsky <yuri@fb.com>
Date: Thu, 28 Jul 2016 19:19:25 -0700
Subject: [PATCH] takeOwnershipOfPipes method releases memory

Summary: takeOwnershipOfPipes should left zero heap memory allocated in folly:Subprocess class instance.

Reviewed By: snarkmaster

Differential Revision: D3638503

fbshipit-source-id: aac7b10bd7399c44868f32c01164f4123892598f
---
 folly/Subprocess.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/folly/Subprocess.cpp b/folly/Subprocess.cpp
index 1e294ba7..d7d28d9f 100644
--- a/folly/Subprocess.cpp
+++ b/folly/Subprocess.cpp
@@ -832,7 +832,8 @@ std::vector<Subprocess::ChildPipe> Subprocess::takeOwnershipOfPipes() {
   for (auto& p : pipes_) {
     pipes.emplace_back(p.childFd, std::move(p.pipe));
   }
-  pipes_.clear();
+  // release memory
+  std::vector<Pipe>().swap(pipes_);
   return pipes;
 }
 
-- 
2.34.1