use std::forward instead of std::move on objects whose types have been deduced; don...
authorEric Niebler <eniebler@fb.com>
Thu, 28 Apr 2016 23:39:30 +0000 (16:39 -0700)
committerFacebook Github Bot 8 <facebook-github-bot-8-bot@fb.com>
Thu, 28 Apr 2016 23:50:30 +0000 (16:50 -0700)
commitf73c72490fee4b2fd747aa4b08bd7490c1c76873
tree2f2e191ba72d48620205794562d675947b9be709
parent95e7a3bad41357c9f78d0a993b542b002f17e00e
use std::forward instead of std::move on objects whose types have been deduced; don't take the sizeof incomplete types

Summary: Pretty sure std::forward is needed here instead of std::move. If you trace the call chain to see where the types of the objects come from, you'll see they can be deduced to be lvalues, so std::forward is the right choice. Also, moved some dicey looking code that appeared to be taking the size of some incomkplete types.

Reviewed By: spacedentist

Differential Revision: D3214199

fb-gh-sync-id: 778190ffb25a648b839760a3dddfad8dc6d41c88
fbshipit-source-id: 778190ffb25a648b839760a3dddfad8dc6d41c88
folly/experimental/fibers/FiberManager-inl.h